| Summary: | FTL should force LLVM to use our own JIT memory allocator, and we shouldn't have to keep around an LLVMExecutionEngineRef to keep code alive | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 112840, 113620 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Filip Pizlo
2013-03-29 16:08:20 PDT
Created attachment 201888 [details]
LLVM patch to expose MCJITMemoryManager callbacks
Created attachment 201889 [details]
the patch
Created attachment 201890 [details]
LLVM patch to expose MCJITMemoryManager callbacks
Comment on attachment 201889 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=201889&action=review r=me > Source/JavaScriptCore/ftl/FTLCompile.cpp:43 > +static uint8_t *allocateCodeSection( Move the star, please. And below. > Source/JavaScriptCore/ftl/FTLCompile.cpp:54 > + state.graph.m_vm, size, state.graph.m_codeBlock, JITCompilationMustSucceed); Maybe link to the bug here about must succeed. Created attachment 201909 [details]
LLVM patch to expose MCJITMemoryManager callbacks
Created attachment 202207 [details]
new patch for LLVM
Created attachment 202208 [details]
the patch
Landed in http://trac.webkit.org/changeset/150520 |