Summary: | [Qt] Remove WorkQueue related functions from TestRunnerQt. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zeno Albisser <zeno> | ||||
Component: | New Bugs | Assignee: | Zeno Albisser <zeno> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | benjamin, hausmann, jturcotte | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 109677, 113863 | ||||||
Attachments: |
|
Description
Zeno Albisser
2013-03-27 05:06:53 PDT
Created attachment 195283 [details]
Patch
Comment on attachment 195283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195283&action=review > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:-334 > - for (int i = 0; i != howFarBackward; ++i) > - WorkQueue::shared()->queue(new BackItem(1)); This might regress http://trac.webkit.org/changeset/69073 Please check. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:-341 > - for (int i = 0; i != howFarForward; ++i) > - WorkQueue::shared()->queue(new ForwardItem(1)); ditto > Tools/DumpRenderTree/qt/WorkQueueItemQt.cpp:36 > +#include <qwebpage.h> Nit: I might be missing it but I can't see a reference to QWebPage in the added code. === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. |