Summary: | EWS should use a human readable port name when uploading layout test archives | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, alancutter, dpranke, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 92033 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-03-22 14:21:02 PDT
Created attachment 194632 [details]
Fixes the bug
Comment on attachment 194632 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=194632&action=review > Tools/Scripts/webkitpy/tool/bot/botinfo.py:34 > + def __init__(self, tool, port_name): > self._tool = tool > + self._port_name = port_name Kinda lame that it can't get this off the tool, but I tool doesn't have a modern Port object yet? dpranke would know. There is some dependency inversion currently as the modern "Port" object is also the "host" god-object for the layout_tests sub-system. Host was created to solve this, but the dependncy has yet to be righted yet iirc. Comment on attachment 194632 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=194632&action=review >> Tools/Scripts/webkitpy/tool/bot/botinfo.py:34 >> + self._port_name = port_name > > Kinda lame that it can't get this off the tool, but I tool doesn't have a modern Port object yet? dpranke would know. There is some dependency inversion currently as the modern "Port" object is also the "host" god-object for the layout_tests sub-system. Host was created to solve this, but the dependncy has yet to be righted yet iirc. I thought I had added one at some point, but I guess not. Committed r146691: <http://trac.webkit.org/changeset/146691> |