Bug 112949

Summary: Coordinates.idl lacks Conditional=GEOLOCATION
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, esprehn+autocc, ojan.autocc, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 112975    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Steve Block
Reported 2013-03-21 12:20:10 PDT
Coordinates.idl was added in http://trac.webkit.org/changeset/41650 and is used only by Geolocation. http://trac.webkit.org/changeset/56781 added the ENABLE_GEOLOCATION guard, but missed Coordinates.idl.
Attachments
Patch (1.10 KB, patch)
2013-03-21 14:09 PDT, rich cannings 		no flags
DetailsFormatted DiffDiff
Patch (1.18 KB, patch)
2013-03-22 12:01 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
rich cannings
Comment 1 2013-03-21 14:09:47 PDT
Created attachment 194334 [details] Patch
EFL EWS Bot
Comment 2 2013-03-21 14:26:28 PDT
Comment on attachment 194334 [details] Patch Attachment 194334 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17247268
Adam Barth
Comment 3 2013-03-21 14:27:10 PDT
Comment on attachment 194334 [details] Patch Should this move into Source/WebCore/Modules/geolocation ?
Steve Block
Comment 4 2013-03-21 15:05:10 PDT
> Should this move into Source/WebCore/Modules/geolocation ? Yes - https://bugs.webkit.org/show_bug.cgi?id=112945
Steve Block
Comment 5 2013-03-21 16:07:56 PDT
The EFL failure is because the custom bindings for Coordinates aren't guarded with GEOLOCATION. It seems a shame to add more guards there, but I think the problem can be avoided. The bindings generator now supports nullable types, so we should be able to remove the custom bindings altogether - Bug 112975
Build Bot
Comment 6 2013-03-21 22:08:34 PDT
Comment on attachment 194334 [details] Patch Attachment 194334 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17169891
Steve Block
Comment 7 2013-03-22 12:01:20 PDT
Created attachment 194612 [details] Patch
Steve Block
Comment 8 2013-03-22 12:19:45 PDT
Comment on attachment 194612 [details] Patch Carrying forward abarth's r+
WebKit Review Bot
Comment 9 2013-03-22 13:16:33 PDT
Comment on attachment 194612 [details] Patch Clearing flags on attachment: 194612 Committed r146645: <http://trac.webkit.org/changeset/146645>
WebKit Review Bot
Comment 10 2013-03-22 13:16:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.