Bug 112945

Summary: Move page/Coordinates.[h|idl] to Modules/geolocation/
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, buildbot, esprehn+autocc, gyuyoung.kim, haraken, ojan.autocc, rakuco, rniwa, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Steve Block
Reported 2013-03-21 11:50:30 PDT
Coordinates.[h|idl] are used only by Geolocation. It looks like they were missed in https://bugs.webkit.org/show_bug.cgi?id=79204
Attachments
Patch (30.78 KB, patch)
2013-03-21 18:01 PDT, rich cannings 		no flags
DetailsFormatted DiffDiff
Patch (30.78 KB, patch)
2013-03-21 19:46 PDT, rich cannings 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
rich cannings
Comment 1 2013-03-21 18:01:07 PDT
Created attachment 194407 [details] Patch
Build Bot
Comment 2 2013-03-21 18:51:01 PDT
Comment on attachment 194407 [details] Patch Attachment 194407 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17213840
rich cannings
Comment 3 2013-03-21 19:46:00 PDT
Created attachment 194422 [details] Patch
Steve Block
Comment 4 2013-03-21 19:47:25 PDT
Fixed XCode hashes
Kentaro Hara
Comment 5 2013-03-21 21:29:08 PDT
You might want to add '#if ENABLE(GEOLOCATION)' to the header file and 'Conditional=GEOLOCATION' to the idl file.
Steve Block
Comment 6 2013-03-22 00:05:37 PDT
> You might want to add '#if ENABLE(GEOLOCATION)' to the header file and 'Conditional=GEOLOCATION' to the idl file. Yes, I'm doing that in Bug 112949
Kentaro Hara
Comment 7 2013-03-22 00:06:31 PDT
Comment on attachment 194422 [details] Patch OK.
Steve Block
Comment 8 2013-03-22 00:08:06 PDT
Comment on attachment 194422 [details] Patch Carrying forward abarth's r+
WebKit Review Bot
Comment 9 2013-03-22 00:54:34 PDT
Comment on attachment 194422 [details] Patch Clearing flags on attachment: 194422 Committed r146570: <http://trac.webkit.org/changeset/146570>
WebKit Review Bot
Comment 10 2013-03-22 00:54:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.