Bug 112680

Summary: REGRESSION(r146174): It made jquery/manipulation.html fail on 32 bit platforms
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: ap, ggaren, kadam, msaboff, ossy, zarvai
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 79666, 112609    
Attachments:
Description Flags
diff from bot archive none

Csaba Osztrogonác
Reported 2013-03-19 04:13:38 PDT
http://trac.webkit.org/changeset/146174 and http://trac.webkit.org/changeset/146178 made jquery/manipulation.html fail on 32 bit platforms. At least on Qt, because only Qt has 32 bit tester bot. See this diff for details: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r146178%20%2830468%29/jquery/manipulation-pretty-diff.html
Attachments
diff from bot archive (2.84 KB, patch)
2014-07-31 10:47 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ádám Kallai
Comment 1 2013-03-19 06:27:28 PDT
Skipped in: http://trac.webkit.org/changeset/146201
Michael Saboff
Comment 2 2013-03-19 08:35:18 PDT
(In reply to comment #0) > http://trac.webkit.org/changeset/146174 and http://trac.webkit.org/changeset/146178 made > jquery/manipulation.html fail on 32 bit platforms. At least on Qt, because only Qt > has 32 bit tester bot. See this diff for details: > > http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r146178%20%2830468%29/jquery/manipulation-pretty-diff.html Was there a crash with backtrace as well?
Csaba Osztrogonác
Comment 3 2013-03-19 08:50:13 PDT
No, It is only fail, not crash.
Michael Saboff
Comment 4 2013-03-19 13:28:58 PDT
Built r146178 32bit Mac WebKit and jquery/manipulation.html works fine for me.
Alexey Proskuryakov
Comment 5 2014-07-31 10:29:21 PDT
This test is very slow, particularly in debug builds, but there doesn't appear to be anything 32-bit specific there any more. OK to close?
Csaba Osztrogonác
Comment 6 2014-07-31 10:47:26 PDT
Created attachment 235831 [details] diff from bot archive
Csaba Osztrogonác
Comment 7 2014-07-31 10:53:05 PDT
(In reply to comment #5) > This test is very slow, particularly in debug builds, but there doesn't appear to be anything 32-bit specific there any more. OK to close? It is ~1.5 years old bug, who knows what happened during this long period. There isn't QtWebKit anymore, there isn't any EFL or GTK 32 bit tester bot. We only know that it was a valid 32 bit regression (diff attached) caused by r146174 and r146178. And the test runtime wasn't slow at all, it ran on the bot in 2 seconds, so it wasn't related to slowness at all.
Csaba Osztrogonác
Comment 8 2014-07-31 10:59:27 PDT
I checked it on QtWebKit release branch (branched before removing from trunk) and it passes now, so I assume it is already fixed on trunk too.
Note You need to log in before you can comment on or make changes to this bug.