Summary: | Implement and32 on MIPS platform | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | CC: | fpizlo, fu, galpeter, gergely, kilvadyb, oliver, ossy, rgabor, webkit.review.bot, zherczeg | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 112599 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2013-03-18 23:45:57 PDT
Please rename the bug. The 'and32' is missing not the 'add32'. Created attachment 193755 [details]
speculative fix
A MIPS guru should check this patch just to be on safe side.
Thanks for the patch, Balázs will check it first thing. (In reply to comment #2) > Created an attachment (id=193755) [details] > speculative fix The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests. (In reply to comment #4) > (In reply to comment #2) > > Created an attachment (id=193755) [details] [details] > > speculative fix > > The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests. Ok, in the meantime I think we should commit this in, just to get the bot a little greener. (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > Created an attachment (id=193755) [details] [details] [details] > > > speculative fix > > > > The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests. > > Ok, in the meantime I think we should commit this in, just to get the bot a little greener. Agree. Comment on attachment 193755 [details]
speculative fix
róme
Comment on attachment 193755 [details] speculative fix Clearing flags on attachment: 193755 Committed r146339: <http://trac.webkit.org/changeset/146339> All reviewed patches have been landed. Closing bug. |