| Summary: | Support Windows HTMLSelectElement keystrokes on Chromium win | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dominic Mazzoni <dmazzoni> | ||||||||||
| Component: | Forms | Assignee: | Dominic Mazzoni <dmazzoni> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | antonm, dglazkov, esprehn+autocc, mifenton, ojan.autocc, tkent, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Bug Depends on: | 112540 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
Chromium bug: http://crbug.com/1945 Created attachment 193426 [details]
Patch
Comment on attachment 193426 [details] Patch Attachment 193426 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17114586 Created attachment 193428 [details]
Patch
Comment on attachment 193428 [details] Patch Attachment 193428 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17184237 Created attachment 193431 [details]
Patch
Comment on attachment 193431 [details]
Patch
ok.
Using OS() and PLATFORM() in WebCore is not nice, but they already exist in these files.
Comment on attachment 193431 [details] Patch Clearing flags on attachment: 193431 Committed r146035: <http://trac.webkit.org/changeset/146035> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 112540 That lead to Windows debug build failures: 32>..\html\HTMLSelectElementWin.cpp(53): error C2220: warning treated as error - no 'object' file generated 32>..\html\HTMLSelectElementWin.cpp(53): warning C4018: '<' : signed/unsigned mismatch I've reverted the patch? Sorry about the build failure. That's weird, I definitely built Chromium on Windows to test this patch, so I'm not sure why I didn't see that failure. Anyway, should be easy to fix. (In reply to comment #12) > Sorry about the build failure. That's weird, I definitely built Chromium on Windows to test this patch, so I'm not sure why I didn't see that failure. Anyway, should be easy to fix. Maybe you forgot to do debug build, just wildguessing. Created attachment 193579 [details]
Patch
Comment on attachment 193579 [details]
Patch
ok
Comment on attachment 193579 [details] Patch Clearing flags on attachment: 193579 Committed r146145: <http://trac.webkit.org/changeset/146145> All reviewed patches have been landed. Closing bug. |
This bug added support for Windows-specific keystrokes to drop down the option list from a combo box: https://bugs.webkit.org/show_bug.cgi?id=22232 - Alt + Down Arrow in Combo box should show the drop down option box, as should F4) fixed However, this code is only compiled on PLATFORM(WINDOWS). We should be using it on all platforms, when OS(WINDOWS).