Bug 112460

Summary: Support Windows HTMLSelectElement keystrokes on Chromium win
Product: WebKit Reporter: Dominic Mazzoni <dmazzoni>
Component: FormsAssignee: Dominic Mazzoni <dmazzoni>
Status: RESOLVED FIXED    
Severity: Normal CC: antonm, dglazkov, esprehn+autocc, mifenton, ojan.autocc, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on: 112540    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Dominic Mazzoni
Reported 2013-03-15 13:15:01 PDT
This bug added support for Windows-specific keystrokes to drop down the option list from a combo box: https://bugs.webkit.org/show_bug.cgi?id=22232 - Alt + Down Arrow in Combo box should show the drop down option box, as should F4) fixed However, this code is only compiled on PLATFORM(WINDOWS). We should be using it on all platforms, when OS(WINDOWS).
Attachments
Patch (2.15 KB, patch)
2013-03-16 01:14 PDT, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Patch (2.83 KB, patch)
2013-03-16 01:32 PDT, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Patch (2.82 KB, patch)
2013-03-16 01:48 PDT, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Patch (3.10 KB, patch)
2013-03-18 09:18 PDT, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dominic Mazzoni
Comment 1 2013-03-15 13:15:28 PDT
Chromium bug: http://crbug.com/1945
Dominic Mazzoni
Comment 2 2013-03-16 01:14:40 PDT
Created attachment 193426 [details] Patch
WebKit Review Bot
Comment 3 2013-03-16 01:23:26 PDT
Comment on attachment 193426 [details] Patch Attachment 193426 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17114586
Dominic Mazzoni
Comment 4 2013-03-16 01:32:46 PDT
Created attachment 193428 [details] Patch
WebKit Review Bot
Comment 5 2013-03-16 01:44:03 PDT
Comment on attachment 193428 [details] Patch Attachment 193428 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17184237
Dominic Mazzoni
Comment 6 2013-03-16 01:48:18 PDT
Created attachment 193431 [details] Patch
Kent Tamura
Comment 7 2013-03-17 15:05:08 PDT
Comment on attachment 193431 [details] Patch ok. Using OS() and PLATFORM() in WebCore is not nice, but they already exist in these files.
WebKit Review Bot
Comment 8 2013-03-17 23:28:06 PDT
Comment on attachment 193431 [details] Patch Clearing flags on attachment: 193431 Committed r146035: <http://trac.webkit.org/changeset/146035>
WebKit Review Bot
Comment 9 2013-03-17 23:28:09 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2013-03-18 01:34:24 PDT
Re-opened since this is blocked by bug 112540
anton muhin
Comment 11 2013-03-18 01:35:17 PDT
That lead to Windows debug build failures: 32>..\html\HTMLSelectElementWin.cpp(53): error C2220: warning treated as error - no 'object' file generated 32>..\html\HTMLSelectElementWin.cpp(53): warning C4018: '<' : signed/unsigned mismatch I've reverted the patch?
Dominic Mazzoni
Comment 12 2013-03-18 09:14:23 PDT
Sorry about the build failure. That's weird, I definitely built Chromium on Windows to test this patch, so I'm not sure why I didn't see that failure. Anyway, should be easy to fix.
anton muhin
Comment 13 2013-03-18 09:17:35 PDT
(In reply to comment #12) > Sorry about the build failure. That's weird, I definitely built Chromium on Windows to test this patch, so I'm not sure why I didn't see that failure. Anyway, should be easy to fix. Maybe you forgot to do debug build, just wildguessing.
Dominic Mazzoni
Comment 14 2013-03-18 09:18:22 PDT
Created attachment 193579 [details] Patch
Kent Tamura
Comment 15 2013-03-18 15:54:09 PDT
Comment on attachment 193579 [details] Patch ok
WebKit Review Bot
Comment 16 2013-03-18 16:13:16 PDT
Comment on attachment 193579 [details] Patch Clearing flags on attachment: 193579 Committed r146145: <http://trac.webkit.org/changeset/146145>
WebKit Review Bot
Comment 17 2013-03-18 16:13:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.