Bug 112250
| Summary: | [V8] Pass the correct world type to V8PerIsolateData::hasInstance. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marja Hölttä <marja> |
| Component: | New Bugs | Assignee: | Marja Hölttä <marja> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | dcarney, haraken |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 112165 | ||
Marja Hölttä
Making V8PerIsolateData::hasInstance do the check according to the passed world type uncovers problems:
- v8::Handle<v8::Value> V8Document::evaluateMethodCustom(const v8::Arguments& args) seems to have the wrong node (main world instead of isolated world) in args, and HasInstance fails there. -> ExecuteScriptApiTest.ExecuteScriptFrameAfterLoad (chromium browser_tests) fails
- crash in contextHasCorrectPrototype -> ExecuteScriptApiTest.ExecuteScriptCallback (chromium browser_tests) fails.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marja Hölttä
This got done as a side effect of some other patch. We need to check multiple worlds in some cases though (if we're going through NPAPI, we don't have a context and can't get the world from there).