Bug 112211

Summary: [CSS Grid Layout] Refactor GridCoordinate to hold GridSpans
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 103314    
Attachments:
Description Flags
Proposed change 1: Not super happy about the emptyGridArea change but a pair would be worse. none

Julien Chaffraix
Reported 2013-03-12 17:04:27 PDT
After bug 111653, we have the code to compute both initial / final positions in one direction and using GridSpan. However this information is local and isn't propagated to most of the layout code. Instead of peppering more GridSpan computation, we should propagate the information through GridCoordinate. This is a good candidate as it is our golden representation of where an item is on the grid.
Attachments
Proposed change 1: Not super happy about the emptyGridArea change but a pair would be worse. (11.78 KB, patch)
2013-03-12 17:37 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2013-03-12 17:37:33 PDT
Created attachment 192842 [details] Proposed change 1: Not super happy about the emptyGridArea change but a pair would be worse.
WebKit Review Bot
Comment 2 2013-03-13 15:30:27 PDT
Comment on attachment 192842 [details] Proposed change 1: Not super happy about the emptyGridArea change but a pair would be worse. Clearing flags on attachment: 192842 Committed r145762: <http://trac.webkit.org/changeset/145762>
WebKit Review Bot
Comment 3 2013-03-13 15:30:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.