Bug 111959

Summary: Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aboxhall, apinheiro, ap, cfleizach, dmazzoni, esprehn+autocc, haraken, japhet, jdiggs, mifenton, ojan.autocc, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111923    
Attachments:
Description Flags
Patch
none
Patch for landing none

jochen
Reported 2013-03-11 01:10:30 PDT
Replace DefinitelyProcessingUserGesture with DefinitelyProcessingNewUserGesture
Attachments
Patch (37.29 KB, patch)
2013-03-11 01:12 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.34 KB, patch)
2013-03-11 14:16 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-03-11 01:12:32 PDT
Created attachment 192419 [details] Patch
jochen
Comment 2 2013-03-11 01:15:02 PDT
Adam, what do you think about this? Some background: In EventHandler.cpp when processing e.g. a mouse press event, we pass on the event to a subframe's EventHandler if it wasn't handled. The subframe creates another UserGestureIndicator which currently increases the consumable gestures count. That way, a web page can create arbitrarily many gestures by stacking iframes on top of each other.
jochen
Comment 3 2013-03-11 13:24:44 PDT
Alexey, this change touches WebKit2, can you please review it?
Adam Barth
Comment 4 2013-03-11 13:34:48 PDT
Comment on attachment 192419 [details] Patch LGTM
Alexey Proskuryakov
Comment 5 2013-03-11 13:39:36 PDT
Comment on attachment 192419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192419&action=review rs=me on WebKit2 part. > Source/WebCore/ChangeLog:3 > + Replace DefinitelyProcessingUserGesture with DefinitelyProcessingNewUserGesture I'd say "rename" to make it more clear why there is no behavior change.
jochen
Comment 6 2013-03-11 14:16:42 PDT
Created attachment 192556 [details] Patch for landing
WebKit Review Bot
Comment 7 2013-03-11 18:18:08 PDT
Comment on attachment 192556 [details] Patch for landing Clearing flags on attachment: 192556 Committed r145453: <http://trac.webkit.org/changeset/145453>
WebKit Review Bot
Comment 8 2013-03-11 18:18:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.