| Summary: | Move platform-specific typedefs to PlatformMenuDescription.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jesus Sanchez-Palencia <jesus> | ||||||||
| Component: | WebCore Misc. | Assignee: | Jesus Sanchez-Palencia <jesus> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aroben, cmarcelo, gyuyoung.kim, kenneth, laszlo.gombos, mpakulavelrutka, rakuco, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 111874, 111877, 111882 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jesus Sanchez-Palencia
2013-03-08 11:18:16 PST
Created attachment 192259 [details]
Patch
Can I ask a question ? I wonder how to implement context menu under this change. As you know, existing context menu implementation just provides APIs that application can implement context menu on EFL port. Do you have plan to change the existing context menu implementation ? CC'ing Michal Pakula vel Rutka. (In reply to comment #2) > Can I ask a question ? I wonder how to implement context menu under this change. As you know, existing context menu implementation just provides APIs that application can implement context menu on EFL port. Do you have plan to change the existing context menu implementation ? > > CC'ing Michal Pakula vel Rutka. I guess your question was more suit in https://bugs.webkit.org/show_bug.cgi?id=111877, right? No, this work won't change your existing context menu implementation. I'm following it closely Pakula's patches and your use-case (the application is responsible for rendering the menu and letting WebKit know about the selected item) will be kept untouched. All this USE flag does is to reduce the amount of platform-specific code in WebCore/platform/ContextMenu* files. (In reply to comment #0) > The typedefs to NativeMenu and NativeItem fit better in PlatformMenuDescription.h, which is the header meant to this. I think they would fit better into a new file PlatformContextMenu.h, but is convenient to use the existing file. Maybe a comment to indicate that you'll rename this file once get rid of PlatformMenuDescription? I also suggest rename the type to PlatformContextMenu, to compensate for losing the class scope you had before (ContextMenu::NativeMenu). Created attachment 192953 [details]
Patch
Created attachment 192963 [details]
Patch
Comment on attachment 192963 [details] Patch Clearing flags on attachment: 192963 Committed r145827: <http://trac.webkit.org/changeset/145827> All reviewed patches have been landed. Closing bug. |