Bug 111876

Summary:

Move platform-specific typedefs to PlatformMenuDescription.h

Product:

WebKit

Reporter:

Jesus Sanchez-Palencia <jesus>

Component:

WebCore Misc.

Assignee:

Jesus Sanchez-Palencia <jesus>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, cmarcelo, gyuyoung.kim, kenneth, laszlo.gombos, mpakulavelrutka, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

111874, 111877, 111882

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Jesus Sanchez-Palencia

Reported 2013-03-08 11:18:16 PST

The typedefs to NativeMenu and NativeItem fit better in PlatformMenuDescription.h, which is the header meant to this.

Attachments
Patch (3.01 KB, patch) 2013-03-08 11:52 PST, Jesus Sanchez-Palencia	no flags	Details Formatted Diff Diff
Patch (11.29 KB, patch) 2013-03-13 11:37 PDT, Jesus Sanchez-Palencia	no flags	Details Formatted Diff Diff
Patch (13.07 KB, patch) 2013-03-13 12:32 PDT, Jesus Sanchez-Palencia	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jesus Sanchez-Palencia

Comment 1 2013-03-08 11:52:00 PST

Created attachment 192259 [details] Patch

Gyuyoung Kim

Comment 2 2013-03-10 18:39:11 PDT

Can I ask a question ? I wonder how to implement context menu under this change. As you know, existing context menu implementation just provides APIs that application can implement context menu on EFL port. Do you have plan to change the existing context menu implementation ? CC'ing Michal Pakula vel Rutka.

Jesus Sanchez-Palencia

Comment 3 2013-03-11 05:18:31 PDT

(In reply to comment #2) > Can I ask a question ? I wonder how to implement context menu under this change. As you know, existing context menu implementation just provides APIs that application can implement context menu on EFL port. Do you have plan to change the existing context menu implementation ? > > CC'ing Michal Pakula vel Rutka. I guess your question was more suit in https://bugs.webkit.org/show_bug.cgi?id=111877, right? No, this work won't change your existing context menu implementation. I'm following it closely Pakula's patches and your use-case (the application is responsible for rendering the menu and letting WebKit know about the selected item) will be kept untouched. All this USE flag does is to reduce the amount of platform-specific code in WebCore/platform/ContextMenu* files.

Caio Marcelo de Oliveira Filho

Comment 4 2013-03-12 14:25:15 PDT

(In reply to comment #0) > The typedefs to NativeMenu and NativeItem fit better in PlatformMenuDescription.h, which is the header meant to this. I think they would fit better into a new file PlatformContextMenu.h, but is convenient to use the existing file. Maybe a comment to indicate that you'll rename this file once get rid of PlatformMenuDescription? I also suggest rename the type to PlatformContextMenu, to compensate for losing the class scope you had before (ContextMenu::NativeMenu).

Jesus Sanchez-Palencia

Comment 5 2013-03-13 11:37:50 PDT

Created attachment 192953 [details] Patch

Jesus Sanchez-Palencia

Comment 6 2013-03-13 12:32:14 PDT

Created attachment 192963 [details] Patch

WebKit Review Bot

Comment 7 2013-03-14 10:40:38 PDT

Comment on attachment 192963 [details] Patch Clearing flags on attachment: 192963 Committed r145827: <http://trac.webkit.org/changeset/145827>

WebKit Review Bot

Comment 8 2013-03-14 10:40:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.