Bug 111592

Summary:

fast/css/hover-update.html is flaky

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, ojan, pnormand, rakuco, tkent, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Ryosuke Niwa 2013-03-06 10:14:50 PST

webkit.org:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fcss%2Fhover-update.html

chromium.org
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcss%2Fhover-update.html

Comment 1 Ryosuke Niwa 2013-03-06 10:22:30 PST

Added a failing test expectation in http://trac.webkit.org/changeset/144944.

Comment 2 Tony Chang 2013-03-06 10:42:15 PST

*** Bug 85951 has been marked as a duplicate of this bug. ***

Comment 3 Tony Chang 2013-03-06 10:42:39 PST

*** Bug 80246 has been marked as a duplicate of this bug. ***

Comment 4 Tony Chang 2013-03-06 10:46:49 PST

Created attachment 191790 [details]
Patch

Comment 5 Ryosuke Niwa 2013-03-06 10:49:01 PST

Comment on attachment 191790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191790&action=review

Let's try this.

> LayoutTests/fast/css/hover-update.html:31
> +    if (timeSinceStartedCheckingMs < 200 && window.getComputedStyle(document.getElementById('b'), null).backgroundColor != expectedBackgroundColor) {
> +        setTimeout(finish, 10);
> +        return;
> +    }
> +    shouldBeEqualToString("window.getComputedStyle(document.getElementById('b'), null).backgroundColor", expectedBackgroundColor);

Nit: It seems like window. is unnecessary?

Comment 6 Tony Chang 2013-03-06 11:45:04 PST

Comment on attachment 191790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191790&action=review

>> LayoutTests/fast/css/hover-update.html:31
>> +    shouldBeEqualToString("window.getComputedStyle(document.getElementById('b'), null).backgroundColor", expectedBackgroundColor);
> 
> Nit: It seems like window. is unnecessary?

Yeah, I didn't want to change the expected results which lists this string verbatim.

Comment 7 Tony Chang 2013-03-06 11:45:34 PST

Comment on attachment 191790 [details]
Patch

Actually, I can get rid of it in the 'if' above.

Comment 8 Tony Chang 2013-03-06 11:46:53 PST

Created attachment 191805 [details]
Patch for landing

Comment 9 WebKit Review Bot 2013-03-06 12:26:16 PST

Comment on attachment 191805 [details]
Patch for landing

Clearing flags on attachment: 191805

Committed r144963: <http://trac.webkit.org/changeset/144963>

Comment 10 WebKit Review Bot 2013-03-06 12:26:21 PST

All reviewed patches have been landed.  Closing bug.