Bug 111441

Summary: Cache flush problem on ARMv7 JSC
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, fpizlo, hausmann, laszlo.gombos, ojan.autocc, oliver, ossy, psychon, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
proposed fix none

Description Gabor Rapcsanyi 2013-03-05 07:50:09 PST 
The ARMv7 random crash problem is caused by cache flushing. https://bugs.webkit.org/show_bug.cgi?id=108632 just hide the real bug.

The problem is similar to this bug:
https://bugs.webkit.org/show_bug.cgi?id=77712

After changing the cache flush mechanism in ARMv7 to ARM traditional the problem has gone.
Comment 1 Csaba Osztrogonác 2013-03-05 07:58:00 PST 
*** Bug 108632 has been marked as a duplicate of this bug. ***
Comment 2 Csaba Osztrogonác 2013-03-05 07:59:32 PST 
Could you revert Simon's workaround ( http://trac.webkit.org/changeset/144170 ) after or with this patch?
Comment 3 Gabor Rapcsanyi 2013-03-06 06:07:16 PST 
Created attachment 191737 [details]
proposed fix

In another patch we should make it more sophisticated but for now it solves the problem.
I'm also reverting Simon's patch with this.
Comment 4 Csaba Osztrogonác 2013-03-06 09:43:20 PST 
Yay, with this patch there are only 171 remaining inspector crashes on Thumb2,
but they are unrelated to this bug - http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7987
Comment 5 Zoltan Herczeg 2013-03-08 00:27:34 PST 
Comment on attachment 191737 [details]
proposed fix

r=me.

But I think the current flush mechanism invalidates a large amount of unnecessary, so we should improve with it.
Comment 6 WebKit Review Bot 2013-03-08 01:29:48 PST 
Comment on attachment 191737 [details]
proposed fix

Clearing flags on attachment: 191737

Committed r145194: <http://trac.webkit.org/changeset/145194>
Comment 7 WebKit Review Bot 2013-03-08 01:29:52 PST 
All reviewed patches have been landed.  Closing bug.