Bug 111107

Summary: Add private API to disable WKView window occlusion detection
Product: WebKit Reporter: Kiran Muppala <cmuppala>
Component: WebKit2Assignee: Kiran Muppala <cmuppala>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111116    
Attachments:
Description Flags
Patch
none
Patch none

Description Kiran Muppala 2013-02-28 13:31:06 PST 
https://bugs.webkit.org/show_bug.cgi?id=107494, added window occlusion detection support to WKView, which caused some javascript timer related layout tests to fail using WebKitTestRunner.  I submitted a initial fix that just initializes the page visibility in WebKitTestRunner, https://bugs.webkit.org/show_bug.cgi?id=111025, but that still opens the door for other tests to fail if they depend on the view to know it is visible.

Hence, adding a private API to disable window occlusion detection will allow a more robust fix for WebKitTestRunner issues with window occlusion.
Comment 1 Kiran Muppala 2013-02-28 13:31:22 PST 
<rdar://problem/13211598>
Comment 2 Kiran Muppala 2013-02-28 14:00:45 PST 
Created attachment 190803 [details]
Patch
Comment 3 Simon Fraser (smfr) 2013-02-28 14:04:23 PST 
Comment on attachment 190803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190803&action=review

> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63
> +- (void)disableWindowOcclusionDetection;
> +- (void)enableWindowOcclusionDetection;

Normally we'd do this like setWindowOcclustionDetectionEnabled:(BOOL)
Comment 4 Kiran Muppala 2013-02-28 14:27:37 PST 
Created attachment 190808 [details]
Patch
Comment 5 Kiran Muppala 2013-02-28 14:30:52 PST 
(In reply to comment #3)
> (From update of attachment 190803 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190803&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63
> > +- (void)disableWindowOcclusionDetection;
> > +- (void)enableWindowOcclusionDetection;
> 
> Normally we'd do this like setWindowOcclustionDetectionEnabled:(BOOL)

Got it.  I replaced the two methods with a single setter.
Comment 6 WebKit Review Bot 2013-02-28 16:01:08 PST 
Comment on attachment 190808 [details]
Patch

Clearing flags on attachment: 190808

Committed r144389: <http://trac.webkit.org/changeset/144389>
Comment 7 WebKit Review Bot 2013-02-28 16:01:11 PST 
All reviewed patches have been landed.  Closing bug.