Bug 110731

Summary: Make ninja the default build system for build-webkit --chromium on windows
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110758    
Bug Blocks: 104434    
Attachments:
Description Flags
Patch none

Nico Weber
Reported 2013-02-25 00:50:35 PST
Make ninja the default build system for build-webkit --chromium on windows
Attachments
Patch (1.14 KB, patch)
2013-02-25 00:51 PST, Nico Weber
no flags
Nico Weber
Comment 1 2013-02-25 00:51:32 PST
jochen
Comment 2 2013-02-25 00:53:42 PST
Comment on attachment 190014 [details] Patch ok
Nico Weber
Comment 3 2013-02-25 01:34:25 PST
Comment on attachment 190014 [details] Patch Thanks! Let's see what breaks.
WebKit Review Bot
Comment 4 2013-02-25 01:50:35 PST
Comment on attachment 190014 [details] Patch Clearing flags on attachment: 190014 Committed r143895: <http://trac.webkit.org/changeset/143895>
WebKit Review Bot
Comment 5 2013-02-25 01:50:38 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2013-02-25 07:38:13 PST
Re-opened since this is blocked by bug 110758
Dirk Pranke
Comment 7 2013-02-25 15:07:09 PST
trying again ... reenabled in http://trac.webkit.org/changeset/143978
Dirk Pranke
Comment 8 2013-02-25 19:06:24 PST
seems to be happy so far w/ ~5 runs all greenish.
Note You need to log in before you can comment on or make changes to this bug.