Bug 110698

Summary:

getPropertyValue for -webkit-column-rule returns null, should compute the shorthand value

Product:

WebKit

Reporter:

Uday Kiran <udaykiran4u>

Component:

CSS

Assignee:

Sergey Ryazanov <serya>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, buildbot, darin, esprehn+autocc, graouts, joepeck, koivisto, macpherson, menard, mkwst+watchlist, ojan.autocc, rego+ews, rniwa, serya, timothy, udaykiran4u, webkit.review.bot, xan.lopez, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

103244

Attachments:

Description	Flags
Proposed Patch	none
Proposed Patch	none
Updated Patch	none
Updated Patch	none
Patch	buildbot: commit-queue-
My patch accidentally uploaded into a wrong bug. Returning the right patch.	none

Uday Kiran

Reported 2013-02-23 14:28:49 PST

style.getPropertyValue("-webkit-column-rule") returns null.

Attachments
Proposed Patch (6.00 KB, patch) 2013-02-23 14:47 PST, Uday Kiran	no flags	Details Formatted Diff Diff
Proposed Patch (6.00 KB, patch) 2013-02-23 14:54 PST, Uday Kiran	no flags	Details Formatted Diff Diff
Updated Patch (8.02 KB, patch) 2013-02-25 11:00 PST, Uday Kiran	no flags	Details Formatted Diff Diff
Updated Patch (8.09 KB, patch) 2013-02-26 10:13 PST, Uday Kiran	no flags	Details Formatted Diff Diff
Patch (54.30 KB, patch) 2013-02-26 22:27 PST, Sergey Ryazanov	buildbot: commit-queue-	Details Formatted Diff Diff
My patch accidentally uploaded into a wrong bug. Returning the right patch. (8.09 KB, patch) 2013-02-26 23:29 PST, Sergey Ryazanov	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Uday Kiran

Comment 1 2013-02-23 14:47:50 PST

Created attachment 189940 [details] Proposed Patch

Uday Kiran

Comment 2 2013-02-23 14:54:07 PST

Created attachment 189941 [details] Proposed Patch Fixed a typo in bug title.

Alexander Pavlov (apavlov)

Comment 3 2013-02-24 23:53:56 PST

Comment on attachment 189940 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189940&action=review > LayoutTests/fast/css/getPropertyValue-column-rule.html:24 > + <div id="-webkit-column-rule7" class="test" style="-webkit-column-rule: green;"></div> Would you mind adding an invalid property value case ("-webkit-column-rule: foo" should work, I guess), along with some cases that implicitly specify the shorthand value by setting values of the respective longhands?

Uday Kiran

Comment 4 2013-02-25 11:00:25 PST

Created attachment 190090 [details] Updated Patch Added testcases.

Uday Kiran

Comment 5 2013-02-25 11:04:34 PST

(In reply to comment #3) > (From update of attachment 189940 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189940&action=review > > > LayoutTests/fast/css/getPropertyValue-column-rule.html:24 > > + <div id="-webkit-column-rule7" class="test" style="-webkit-column-rule: green;"></div> > > Would you mind adding an invalid property value case ("-webkit-column-rule: foo" should work, I guess), returns null on firefox 22 and IE10 > along with some cases that implicitly specify the shorthand value by setting values of the respective longhands? Added. If only few longhand properties are specified, getPropertyValue for shorthand property returns null in Firefox and IE10.

Alexander Pavlov (apavlov)

Comment 6 2013-02-25 22:02:17 PST

Comment on attachment 190090 [details] Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190090&action=review Please fix one minor nit, and we are good to land! Please note that this patch will most likely conflict with your other patch for bug 110816, so you will need to rebase the one whichever lands last for the commit-queue to be able to process it. > LayoutTests/fast/css/getPropertyValue-column-rule.html:71 > + </script> This should be unindented 2 spaces, in line with the following <script src=...></script>

Uday Kiran

Comment 7 2013-02-26 10:13:03 PST

Created attachment 190321 [details] Updated Patch Fixed Indentation.

Alexander Pavlov (apavlov)

Comment 8 2013-02-26 21:58:21 PST

Comment on attachment 190321 [details] Updated Patch r=me

WebKit Review Bot

Comment 9 2013-02-26 22:18:30 PST

Comment on attachment 190321 [details] Updated Patch Clearing flags on attachment: 190321 Committed r144146: <http://trac.webkit.org/changeset/144146>

WebKit Review Bot

Comment 10 2013-02-26 22:18:35 PST

All reviewed patches have been landed. Closing bug.

Sergey Ryazanov

Comment 11 2013-02-26 22:27:55 PST

Reopening to attach new patch.

Sergey Ryazanov

Comment 12 2013-02-26 22:27:59 PST

Created attachment 190445 [details] Patch

Build Bot

Comment 13 2013-02-26 23:08:18 PST

Comment on attachment 190445 [details] Patch Attachment 190445 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16798068

Sergey Ryazanov

Comment 14 2013-02-26 23:29:05 PST

Created attachment 190451 [details] My patch accidentally uploaded into a wrong bug. Returning the right patch.

Note You need to log in before you can comment on or make changes to this bug.