Bug 110565

Summary:

Renaming the armv7.rb LLINT backend to arm.rb

Product:

WebKit

Reporter:

Gabor Rapcsanyi <rgabor>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, fpizlo, gyuyoung.kim, oliver, ossy, rakuco, webkit.review.bot, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

97589

Attachments:

Description	Flags
proposed patch	zherczeg: review+, zherczeg: commit-queue-

Description Gabor Rapcsanyi 2013-02-22 01:00:32 PST

This is the first part of making available LLINT for ARM traditional and armv5. First I want to rename everything from armv7 to arm. After that I can add the traditional and armv5 specific stuff to it.

Comment 1 Gabor Rapcsanyi 2013-02-22 04:03:03 PST

Created attachment 189743 [details]
proposed patch

Comment 2 Gabor Rapcsanyi 2013-02-26 06:19:00 PST

Filip could you take a look at this please?
The following patch would be this: 
  https://bugs.webkit.org/show_bug.cgi?id=97589

Comment 3 Csaba Osztrogonác 2013-03-05 08:02:26 PST

ping for review, please :)

Comment 4 Zoltan Herczeg 2013-03-06 04:01:55 PST

This patch looks sane for me, so if noone has any objections, I will give an r+.

Comment 5 Zoltan Herczeg 2013-03-12 02:17:26 PDT

Comment on attachment 189743 [details]
proposed patch

There was no objections, so it is time for a review. The patch is quite old now, so please update it before land.

View in context: https://bugs.webkit.org/attachment.cgi?id=189743&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        The first step to making a common ARM backend in LLINT
> +        for ARMv5, ARMv7 and ARMv7 traditional.

A little more details please.

Comment 6 Gabor Rapcsanyi 2013-03-12 02:35:42 PDT

Thanks for the review!
Patch landed: http://trac.webkit.org/changeset/145504