Bug 110262

Summary: [Chromium] Move WebKitPlatformSupport declaration to Platform.h
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, enne, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 106457    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch none

Description Mark Pilgrim (Google) 2013-02-19 14:20:50 PST 
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
Comment 1 Mark Pilgrim (Google) 2013-02-19 14:22:25 PST 
Created attachment 189160 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-19 14:25:55 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Dimitri Glazkov (Google) 2013-02-19 14:28:44 PST 
Comment on attachment 189160 [details]
Patch

whoa.
Comment 4 Adam Barth 2013-02-19 14:30:24 PST 
Comment on attachment 189160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189160&action=review

> Source/Platform/chromium/public/Platform.h:491
> +class WebKitPlatformSupport : public Platform {
> +protected:
> +    ~WebKitPlatformSupport() { }
> +};

We should change all consumers to use the name WebKit::Platform instead.  :)
Comment 5 Mark Pilgrim (Google) 2013-02-19 14:40:16 PST 
(In reply to comment #4)
> We should change all consumers to use the name WebKit::Platform instead.  :)

It's on my list. I want this change first, then update all the #includes downstream ( https://codereview.chromium.org/11824036/ ), then we can remove the entire WK/chromium/public/platform directory.
Comment 6 WebKit Review Bot 2013-02-19 16:16:07 PST 
Comment on attachment 189160 [details]
Patch

Clearing flags on attachment: 189160

Committed r143401: <http://trac.webkit.org/changeset/143401>
Comment 7 WebKit Review Bot 2013-02-19 16:16:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Adrienne Walker 2013-02-19 16:24:49 PST 
This was reverted along with r143382 for reason:

Breaks Chromium win/mac canary compilation

Committed r143403: <http://trac.webkit.org/changeset/143403>
Comment 9 Mark Pilgrim (Google) 2013-02-20 12:00:14 PST 
Build breakage was fixed, rolled DEPS, let's give this another shot.
Comment 10 WebKit Review Bot 2013-02-20 13:32:58 PST 
Comment on attachment 189160 [details]
Patch

Clearing flags on attachment: 189160

Committed r143496: <http://trac.webkit.org/changeset/143496>
Comment 11 WebKit Review Bot 2013-02-20 13:33:02 PST 
All reviewed patches have been landed.  Closing bug.