Bug 110262 – [Chromium] Move WebKitPlatformSupport declaration to Platform.h

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Mark Pilgrim (Google)]

[Chromium] Move WebKitPlatformSupport declaration to Platform.h

[Mark Pilgrim (Google)]

Created attachment 189160 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Dimitri Glazkov (Google)]

Comment on attachment 189160 [details]
Patch

whoa.

[Adam Barth]

Comment on attachment 189160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189160&action=review

> Source/Platform/chromium/public/Platform.h:491
> +class WebKitPlatformSupport : public Platform {
> +protected:
> +    ~WebKitPlatformSupport() { }
> +};

We should change all consumers to use the name WebKit::Platform instead.  :)

[Mark Pilgrim (Google)]

(In reply to comment #4)
> We should change all consumers to use the name WebKit::Platform instead.  :)

It's on my list. I want this change first, then update all the #includes downstream ( https://codereview.chromium.org/11824036/ ), then we can remove the entire WK/chromium/public/platform directory.

[WebKit Review Bot]

Comment on attachment 189160 [details]
Patch

Clearing flags on attachment: 189160

Committed r143401: <http://trac.webkit.org/changeset/143401>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adrienne Walker]

This was reverted along with r143382 for reason:

Breaks Chromium win/mac canary compilation

Committed r143403: <http://trac.webkit.org/changeset/143403>

[Mark Pilgrim (Google)]

Build breakage was fixed, rolled DEPS, let's give this another shot.

[WebKit Review Bot]

Comment on attachment 189160 [details]
Patch

Clearing flags on attachment: 189160

Committed r143496: <http://trac.webkit.org/changeset/143496>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.