Bug 110002

Summary: Add WebKitCSSMatrix to FeatureObserver
Product: WebKit Reporter: Dirk Schulze <krit>
Component: WebCore Misc.Assignee: Dirk Schulze <krit>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, dbates, dino, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110001    
Attachments:
Description Flags
Patch abarth: review-

Dirk Schulze
Reported 2013-02-15 20:32:37 PST
At some point we want to introduce a new API for matrices and deprecate WebKitCSSMatrix. WebKitCSSMatrix is not used anywhere within WebCore. So it is probably not used in the web either. Add the interface to the observer to verify this.
Attachments
Patch (2.29 KB, patch)
2013-02-15 20:39 PST, Dirk Schulze 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2013-02-15 20:39:12 PST
Created attachment 188690 [details] Patch
Adam Barth
Comment 2 2013-02-19 15:13:01 PST
Comment on attachment 188690 [details] Patch This metric isn't really going to tell you anything, unfortunately. Too much code enumerates the global scope, and that will hide any real usage of this feature. Perhaps we should instrument the WebKitCSSMatrix constructor itself?
Dirk Schulze
Comment 3 2013-02-19 15:23:17 PST
(In reply to comment #2) > (From update of attachment 188690 [details]) > This metric isn't really going to tell you anything, unfortunately. Too much code enumerates the global scope, and that will hide any real usage of this feature. Perhaps we should instrument the WebKitCSSMatrix constructor itself? Talked with abarth on IRC. He suggest taking a look at how we instrument new-style notifications. Leaving this on the bug report here as a note. I'll investigate more. Thanks Adam.
Note You need to log in before you can comment on or make changes to this bug.