Summary: | Web Inspector: Introduce ProfilesPanelDescriptor. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eugene Klyuchnikov <eustas> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Eugene Klyuchnikov <eustas> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 109790 | ||||||||
Attachments: |
|
Description
Eugene Klyuchnikov
2013-02-15 00:15:59 PST
Created attachment 188499 [details]
Patch
Comment on attachment 188499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188499&action=review > Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:50 > +WebInspector.ProfilesPanelDescriptor.isUserInitiatedProfile = function(title) { Move { to the next line. > Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:59 > +WebInspector.ProfilesPanelDescriptor.userInitiatedProfileIndex = function(title) { ditto Created attachment 188803 [details]
Patch
Comment on attachment 188499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188499&action=review >> Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:50 >> +WebInspector.ProfilesPanelDescriptor.isUserInitiatedProfile = function(title) { > > Move { to the next line. Done >> Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:59 >> +WebInspector.ProfilesPanelDescriptor.userInitiatedProfileIndex = function(title) { > > ditto Done Comment on attachment 188803 [details] Patch Rejecting attachment 188803 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'validate-changelog', '--non-interactive', 188803, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16611092 Committed r143159: <http://trac.webkit.org/changeset/143159> |