Bug 109906

Summary: Web Inspector: Introduce ProfilesPanelDescriptor.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 109790    
Attachments:
Description Flags
Patch
pfeldman: review+
Patch webkit.review.bot: commit-queue-

Description Eugene Klyuchnikov 2013-02-15 00:15:59 PST 
Some constants/methods should be accessible before ProfilePanel is instantiated.
Comment 1 Eugene Klyuchnikov 2013-02-15 00:37:38 PST 
Created attachment 188499 [details]
Patch
Comment 2 Pavel Feldman 2013-02-15 06:09:37 PST 
Comment on attachment 188499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188499&action=review

> Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:50
> +WebInspector.ProfilesPanelDescriptor.isUserInitiatedProfile = function(title) {

Move { to the next line.

> Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:59
> +WebInspector.ProfilesPanelDescriptor.userInitiatedProfileIndex = function(title) {

ditto
Comment 3 Eugene Klyuchnikov 2013-02-17 23:38:36 PST 
Created attachment 188803 [details]
Patch
Comment 4 Eugene Klyuchnikov 2013-02-17 23:40:18 PST 
Comment on attachment 188499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188499&action=review

>> Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:50
>> +WebInspector.ProfilesPanelDescriptor.isUserInitiatedProfile = function(title) {
> 
> Move { to the next line.

Done

>> Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:59
>> +WebInspector.ProfilesPanelDescriptor.userInitiatedProfileIndex = function(title) {
> 
> ditto

Done
Comment 5 WebKit Review Bot 2013-02-17 23:43:14 PST 
Comment on attachment 188803 [details]
Patch

Rejecting attachment 188803 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'validate-changelog', '--non-interactive', 188803, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16611092
Comment 6 Eugene Klyuchnikov 2013-02-17 23:53:51 PST 
Committed r143159: <http://trac.webkit.org/changeset/143159>