Bug 109888

Summary: ElementData: Move leafy things out of the base class.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, kling, koivisto, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110784    
Bug Blocks: 109505    
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2013-02-14 22:02:06 PST
We should move stuff from ElementData to UniqueElementData or ShareableElementData where it makes sense.
Attachments
Patch (10.18 KB, patch)
2013-02-14 22:05 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-02-14 22:05:19 PST
Created attachment 188479 [details] Patch
WebKit Review Bot
Comment 2 2013-02-15 10:29:54 PST
Comment on attachment 188479 [details] Patch Clearing flags on attachment: 188479 Committed r143014: <http://trac.webkit.org/changeset/143014>
WebKit Review Bot
Comment 3 2013-02-15 10:29:58 PST
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 5 2013-02-15 14:44:29 PST
(In reply to comment #4) > Hello, this broke the Windows build. > http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44333/steps/compile-webkit/logs/stdio Oops! Looks like it was bug 109959. I'll roll that out for now. Whatever happened to the win ews builder?
Adam Barth
Comment 6 2013-02-25 16:18:49 PST
We're checking whether this patch caused a performance regression in bug 110784.
Adam Barth
Comment 7 2013-02-26 00:30:47 PST
Sorry for the noise. This patch was not the problem. I've re-landed it.
Note You need to log in before you can comment on or make changes to this bug.