Bug 109871

Summary:

[Chromium] REGRESSION: Closed Captions button not showing properly

Product:

WebKit

Reporter:

Victor Carbune <vcarbune>

Component:

Media

Assignee:

Silvia Pfeiffer <silviapf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cbiesinger, dglazkov, eric.carlson, eric, esprehn+autocc, feature-media-reviews, jer.noble, ojan.autocc, rniwa, silviapf, syoichi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

43668

Attachments:

Description	Flags
Screenshot	none
get Linux testexpectations	none
Patch	none
remainder patch	none

Description Victor Carbune 2013-02-14 15:59:47 PST

I'm not sure when this actually broke, but the CC button isn't displayed anymore,
though the button exists there (probably the resource isn't painted for some reason?)

It might not be Chromium specific, so if it happens on other ports I'll rename it.

The two pixel tests that would have caught this were marked as requiring
new baselines after webkit.org/b/97800 (but this clearly isn't the cause of the bug)

Comment 1 Victor Carbune 2013-02-14 16:03:49 PST

Created attachment 188444 [details]
Screenshot

Comment 2 Christian Biesinger 2013-02-15 12:18:36 PST

The two tests are
LayoutTests/media/track/track-cue-rendering-horizontal.html
LayoutTests/media/track/track-cue-rendering-vertical.html

I tried to look at them in my Chromium browser, but I can't get any CC-related things to show up (not even the button that doesn't quite display). Am I doing it wrong?

Comment 3 Christian Biesinger 2013-02-15 13:37:19 PST

Oh, figured it out. Need to load this via SimpleHTTPServer to work.

Comment 4 Silvia Pfeiffer 2013-02-18 16:23:43 PST

I have a patch coming up for this (preparing test expectations now) - I honestly have no idea how that button ever showed up! ;-)

Comment 5 Silvia Pfeiffer 2013-02-18 17:08:57 PST

Created attachment 188965 [details]
get Linux testexpectations

Comment 6 WebKit Review Bot 2013-02-18 17:49:51 PST

Comment on attachment 188965 [details]
get Linux testexpectations

Attachment 188965 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16615432

New failing tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html

Comment 7 Christian Biesinger 2013-02-22 16:41:50 PST

Hm... should the new .pngs be in that diff too?

Comment 8 Silvia Pfeiffer 2013-02-22 21:43:27 PST

This is a regression - the images for the caption button have been committed before.

Comment 9 Christian Biesinger 2013-02-25 12:01:38 PST

Well bug 109775 regenerated those PNGs (because the time slider is now slightly different), so the PNGs do need to be regenerated... this is why the cr-linux bot is red for this patch.

Comment 10 Silvia Pfeiffer 2013-02-25 14:32:05 PST

Oh, the test expectations! Sure! I was expecting them to be attached to the bot failure report. (They used to be.) Gotta create them differently now. This wasn't for landing!

Comment 11 Christian Biesinger 2013-02-25 14:43:59 PST

Oh! Heh. Sorry for being unclear!

Comment 12 Silvia Pfeiffer 2013-02-25 20:05:20 PST

Created attachment 190191 [details]
Patch

Comment 13 Silvia Pfeiffer 2013-02-25 20:10:08 PST

Note: checked the images on mountain lion - need to create rebaseline test expectation images after landing

Comment 14 Silvia Pfeiffer 2013-03-02 00:53:57 PST

review ping?

Comment 15 Silvia Pfeiffer 2013-03-10 21:33:13 PDT

Created attachment 192402 [details]
remainder patch

Comment 16 WebKit Review Bot 2013-03-10 22:00:30 PDT

Comment on attachment 192402 [details]
remainder patch

Rejecting attachment 192402 [details] from commit-queue.

silviapf@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

Comment 17 Silvia Pfeiffer 2013-03-10 22:49:05 PDT

Comment on attachment 192402 [details]
remainder patch

Just landed my committer rights, trying to land again.

Comment 18 WebKit Review Bot 2013-03-10 22:49:13 PDT

Comment on attachment 192402 [details]
remainder patch

Rejecting attachment 192402 [details] from commit-queue.

silviapf@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

Comment 19 Build Bot 2013-03-11 01:18:08 PDT

Comment on attachment 192402 [details]
remainder patch

Attachment 192402 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17121076

New failing tests:
editing/selection/selection-modify-crash.html

Comment 20 Silvia Pfeiffer 2013-03-11 01:54:43 PDT

Comment on attachment 192402 [details]
remainder patch

Try again - hopefully I'm now in the committers.py file.

Comment 21 WebKit Review Bot 2013-03-11 02:42:17 PDT

Comment on attachment 192402 [details]
remainder patch

Clearing flags on attachment: 192402

Committed r145347: <http://trac.webkit.org/changeset/145347>

Comment 22 WebKit Review Bot 2013-03-11 02:42:22 PDT

All reviewed patches have been landed.  Closing bug.