Bug 109790

Summary:

Web Inspector: [Console] Add console API message types for profile/profileEnd.

Product:

WebKit

Reporter:

Eugene Klyuchnikov <eustas>

Component:

Web Inspector (Deprecated)

Assignee:

Eugene Klyuchnikov <eustas>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aandrey, apavlov, dglazkov, graouts, joepeck, keishi, loislo, pfeldman, pmuellr, rniwa, timothy, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

109906

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	pfeldman: review+, webkit.review.bot: commit-queue-
Patch	none

Eugene Klyuchnikov

Reported 2013-02-14 00:32:55 PST

Currently likifier plugin is a function that translates link title. This way we have logic about linkified links spread in several files. This patch turns linkier plugin to interface responsible for checking URL, title translation and URL navigation.

Attachments
Patch (11.82 KB, patch) 2013-02-14 01:05 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
Patch (21.46 KB, patch) 2013-02-19 00:12 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
Patch (21.45 KB, patch) 2013-02-19 01:33 PST, Eugene Klyuchnikov	pfeldman: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (26.07 KB, patch) 2013-02-20 08:16 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eugene Klyuchnikov

Comment 1 2013-02-14 01:05:43 PST

Created attachment 188279 [details] Patch

Pavel Feldman

Comment 2 2013-02-14 01:35:03 PST

Comment on attachment 188279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188279&action=review > Source/WebCore/ChangeLog:12 > + This patch turns linkier plugin to interface responsible for checking linkifier > Source/WebCore/inspector/front-end/ProfilesPanel.js:788 > + showProfile: function(typeId, title, uid) title is not used. > Source/WebCore/inspector/front-end/ResourceUtils.js:56 > +WebInspector.ProfileURLRegExp = /webkit-profile:\/\/(.+)\/(.+)#([0-9]+)/; ResourceUtils should know nothing about the profiler.

Eugene Klyuchnikov

Comment 3 2013-02-19 00:12:31 PST

Created attachment 189010 [details] Patch

Timothy Hatcher

Comment 4 2013-02-19 01:29:39 PST

Comment on attachment 189010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189010&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:653 > - showProfile: function(profile) > + showProfile_: function(profile) The underscore should be a prefix not a suffix.

Eugene Klyuchnikov

Comment 5 2013-02-19 01:33:28 PST

Created attachment 189021 [details] Patch

Eugene Klyuchnikov

Comment 6 2013-02-19 01:33:50 PST

Comment on attachment 189010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189010&action=review >> Source/WebCore/inspector/front-end/ProfilesPanel.js:653 >> + showProfile_: function(profile) > > The underscore should be a prefix not a suffix. Fixed.

WebKit Review Bot

Comment 7 2013-02-20 04:08:44 PST

Comment on attachment 189021 [details] Patch Attachment 189021 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16653237 New failing tests: inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html inspector/profiler/cpu-profiler-profiling.html inspector/profiler/heap-snapshot-summary-show-all.html inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html inspector/profiler/heap-snapshot-summary-retainers.html animations/suspend-resume-animation-events.html inspector/audits/audits-panel-functional.html fast/loader/text-document-wrapping.html inspector/profiler/heap-snapshot-comparison-sorting.html inspector/profiler/heap-snapshot-dominators-show-all.html inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html inspector/profiler/heap-snapshot-dominators-show-next.html inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html inspector/profiler/heap-snapshot-comparison-show-next.html inspector/profiler/heap-snapshot-comparison-show-all.html inspector/profiler/canvas2d/canvas-replay-log-grid.html inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html inspector/profiler/heap-snapshot-dominators-sorting.html inspector/profiler/heap-snapshot-reveal-in-dominators-view.html fast/table/border-collapsing/cached-69296.html inspector/profiler/heap-snapshot-comparison-dom-groups-change.html inspector/profiler/heap-snapshot-loader.html inspector/profiler/heap-snapshot-containment-sorting.html inspector/profiler/heap-snapshot-containment-show-all.html inspector/profiler/heap-snapshot-containment-show-next.html inspector/profiler/heap-snapshot-summary-show-next.html inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html fast/loader/javascript-url-in-object.html inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html

Eugene Klyuchnikov

Comment 8 2013-02-20 08:16:11 PST

Created attachment 189322 [details] Patch fixed-tests

Eugene Klyuchnikov

Comment 9 2013-02-21 03:41:14 PST

Committed r143580: <http://trac.webkit.org/changeset/143580>

Andrey Adaikin

Comment 10 2013-02-21 07:31:08 PST

@eustas: plz look at what you have committed: http://trac.webkit.org/changeset/143580/trunk/Source/WebCore/inspector/Inspector.json I'll fix it.

Andrey Adaikin

Comment 11 2013-02-21 08:51:46 PST

(In reply to comment #10) > @eustas: plz look at what you have committed: http://trac.webkit.org/changeset/143580/trunk/Source/WebCore/inspector/Inspector.json > > I'll fix it. Partial roll out: http://trac.webkit.org/changeset/143603

Note You need to log in before you can comment on or make changes to this bug.