Bug 109593

Summary: [GTK] Remove support for compiling with GStreamer 0.10
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, d-r, gustavo, gyuyoung.kim, pnormand, s.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 109734    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2013-02-12 09:30:50 PST
We are about to commit to supporting dependencies until WebKitGTK+ 3.0, so we need to remove dependencies that we don't want to support that long.
Attachments
Patch (6.39 KB, patch)
2013-02-12 13:42 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2013-02-12 09:34:35 PST
You mean the configure.ac bits I guess?
Martin Robinson
Comment 2 2013-02-12 09:35:05 PST
Yep. The code will stay. I've got a patch cooking locally.
Martin Robinson
Comment 3 2013-02-12 13:42:36 PST
Created attachment 187923 [details] Patch
Philippe Normand
Comment 4 2013-02-12 23:29:55 PST
So, while I agree with the rationale, this won't help us maintain the 0.10 code until gst 1.2 is fixed and we can drop the 0.10 support all together :( Maybe we can take a less extreme approach for now? Issue an error is configure is called with --with-gstreamer=0.10 ?
WebKit Review Bot
Comment 5 2013-02-13 09:26:18 PST
Comment on attachment 187923 [details] Patch Clearing flags on attachment: 187923 Committed r142756: <http://trac.webkit.org/changeset/142756>
WebKit Review Bot
Comment 6 2013-02-13 09:26:23 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2013-02-13 12:38:49 PST
Re-opened since this is blocked by bug 109734
Note You need to log in before you can comment on or make changes to this bug.