Summary: | Web Inspector: Introduce version controller to migrate settings versions. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vsevolod Vlasov <vsevik> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Vsevolod Vlasov <vsevik> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 109589 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Vsevolod Vlasov
2013-02-12 00:44:07 PST
Created attachment 187799 [details]
Patch
Comment on attachment 187799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187799&action=review > Source/WebCore/inspector/front-end/Settings.js:352 > +WebInspector.VersionController = function() Maybe WebInspector.Settings.VersionController ? > LayoutTests/inspector/version-controller.html:6 > +{setTimeout(InspectorTest.completeTest.bind(InspectorTest), 1000); Wrong alignment. Why do we need this timeout at all? Committed r142614: <http://trac.webkit.org/changeset/142614> Re-opened since this is blocked by bug 109589 Committed r142725: <http://trac.webkit.org/changeset/142725> |