Bug 109553

Summary: Web Inspector: Introduce version controller to migrate settings versions.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 109589    
Bug Blocks:    
Description Flags
Patch yurys: review+, yurys: commit-queue-

Description Vsevolod Vlasov 2013-02-12 00:44:07 PST
This patch introduces version controller that could be used to migrate inspector settings.
Comment 1 Vsevolod Vlasov 2013-02-12 00:45:29 PST
Created attachment 187799 [details]
Comment 2 Yury Semikhatsky 2013-02-12 01:46:31 PST
Comment on attachment 187799 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=187799&action=review

> Source/WebCore/inspector/front-end/Settings.js:352
> +WebInspector.VersionController = function()

Maybe WebInspector.Settings.VersionController ?

> LayoutTests/inspector/version-controller.html:6
> +{setTimeout(InspectorTest.completeTest.bind(InspectorTest), 1000);

Wrong alignment. Why do we need this timeout at all?
Comment 3 Vsevolod Vlasov 2013-02-12 06:30:52 PST
Committed r142614: <http://trac.webkit.org/changeset/142614>
Comment 4 WebKit Review Bot 2013-02-12 08:33:44 PST
Re-opened since this is blocked by bug 109589
Comment 5 Vsevolod Vlasov 2013-02-12 23:25:44 PST
Committed r142725: <http://trac.webkit.org/changeset/142725>