Summary: | [GTK] Add an optional moduleset with hard to get packages (including libsecret) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | a.renevier, cgarcia, dpranke, gustavo, pnormand, vivekgalatage, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Martin Robinson
2013-02-07 08:26:29 PST
Created attachment 187366 [details]
Patch
Comment on attachment 187366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187366&action=review It looks good but please remove the gyp stuff, which I think is unrelated to this patch ;) > Source/WTF/ChangeLog:10 > + * WTF.gyp/WTF.gyp: Filter out MetaAllocator.(cpp/h) from the Chromium > + build. It's only necessary for GTK+. > + * WTF.gypi: Add MetaAllocator to the build for WebKitGTK+. Is this really related with the scope of this patch? > Source/WebKit/gtk/ChangeLog:12 > + Add an experimental gyp build for WebKitGTK+. Currently only libjavascriptcoregtk, > + jsc, and minidom build (and only on platforms for that support bash). To use the > + build simply run: > + > + $ gyp --generator-output=build --depth=. Source/WebKit/gtk/gyp/JavaScriptCore.gyp Hum, ditto :) Looks like some ChangeLog entries belong to another bug. > Source/JavaScriptCore/JavaScriptCore.gypi:13 > + '<(PRODUCT_DIR)/DerivedSources/JavaScriptCore/Lexer.lut.h', > + '<(PRODUCT_DIR)/DerivedSources/JavaScriptCore/ArrayConstructor.lut.h', Ok I guess this is unrelated as well > Source/WebCore/platform/gtk/GRefPtrGtk.cpp:26 > +#ifdef HAVE_LIBSECRET Perhaps that could be #if HAVE(LIBSECRET) ? Retargeting this bug a bit. Instead of making libsecret optional, it makes sense to add some hard-to-get packages to the jhbuild setup that are just not installed by default. Created attachment 187764 [details]
Patch
Comment on attachment 187764 [details] Patch Clearing flags on attachment: 187764 Committed r142620: <http://trac.webkit.org/changeset/142620> All reviewed patches have been landed. Closing bug. *** Bug 101813 has been marked as a duplicate of this bug. *** *** Bug 101594 has been marked as a duplicate of this bug. *** |