Bug 109159

Summary: [WK2][EFL] Add WKView methods related to background drawing
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit2Assignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, gyuyoung.kim, mikhail.pozdnyakov, rakuco, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107657    
Attachments:
Description Flags
Patch none

Description Kenneth Rohde Christiansen 2013-02-07 02:02:29 PST 
SSIA
Comment 1 Kenneth Rohde Christiansen 2013-02-07 02:04:28 PST 
Created attachment 187026 [details]
Patch
Comment 2 Mikhail Pozdnyakov 2013-02-07 02:23:58 PST 
Comment on attachment 187026 [details]
Patch

LGTM
Comment 3 Chris Dumez 2013-02-07 02:27:47 PST 
Comment on attachment 187026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187026&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:60
> +void WKViewSetDrawsBackground(WKViewRef viewRef, bool flag)

Since the implementation is actually in WebPageProxy, why not add this C API to WKPageEfl ?
Comment 4 Kenneth Rohde Christiansen 2013-02-07 02:30:29 PST 
(In reply to comment #3)
> (From update of attachment 187026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187026&action=review
> 
> > Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:60
> > +void WKViewSetDrawsBackground(WKViewRef viewRef, bool flag)
> 
> Since the implementation is actually in WebPageProxy, why not add this C API to WKPageEfl ?

Two reasons: 1) I believe this belong to the view. 2) Follow what the Nix port does.
Comment 5 Build Bot 2013-02-07 05:34:34 PST 
Comment on attachment 187026 [details]
Patch

Attachment 187026 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16430137

New failing tests:
http/tests/cache/cached-main-resource.html
Comment 6 Kenneth Rohde Christiansen 2013-02-07 05:35:11 PST 
(In reply to comment #5)
> (From update of attachment 187026 [details])
> Attachment 187026 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://queues.webkit.org/results/16430137
> 
> New failing tests:
> http/tests/cache/cached-main-resource.html

Unrelated
Comment 7 WebKit Review Bot 2013-02-07 11:20:42 PST 
Comment on attachment 187026 [details]
Patch

Clearing flags on attachment: 187026

Committed r142157: <http://trac.webkit.org/changeset/142157>
Comment 8 WebKit Review Bot 2013-02-07 11:20:46 PST 
All reviewed patches have been landed.  Closing bug.