SSIA
Created attachment 187026 [details] Patch
Comment on attachment 187026 [details] Patch LGTM
Comment on attachment 187026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187026&action=review > Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:60 > +void WKViewSetDrawsBackground(WKViewRef viewRef, bool flag) Since the implementation is actually in WebPageProxy, why not add this C API to WKPageEfl ?
(In reply to comment #3) > (From update of attachment 187026 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187026&action=review > > > Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:60 > > +void WKViewSetDrawsBackground(WKViewRef viewRef, bool flag) > > Since the implementation is actually in WebPageProxy, why not add this C API to WKPageEfl ? Two reasons: 1) I believe this belong to the view. 2) Follow what the Nix port does.
Comment on attachment 187026 [details] Patch Attachment 187026 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16430137 New failing tests: http/tests/cache/cached-main-resource.html
(In reply to comment #5) > (From update of attachment 187026 [details]) > Attachment 187026 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://queues.webkit.org/results/16430137 > > New failing tests: > http/tests/cache/cached-main-resource.html Unrelated
Comment on attachment 187026 [details] Patch Clearing flags on attachment: 187026 Committed r142157: <http://trac.webkit.org/changeset/142157>
All reviewed patches have been landed. Closing bug.