Bug 109060 – Use GL typedefs in WebGLRenderingContext.idl

• Component: WebGL
• Status: RESOLVED FIXED

[Andrey Adaikin]

Once we support typedefs in WebKit IDL parser we should use GL typedefs in WebGLRenderingContext.idl according to specs.

[Andrey Adaikin]

Created attachment 187070 [details]
Patch

[Early Warning System Bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16435138

[EFL EWS Bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16438135

[Early Warning System Bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16427122

[Build Bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16430158

[kov's GTK+ EWS bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16418164

[WebKit Review Bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16428194

[Peter Beverloo (cr-android ews)]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16428180

[Build Bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16415311

[WebKit Review Bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16408383

[Andrey Adaikin]

Sorry for the bots warnings. This patch depends on https://bugs.webkit.org/show_bug.cgi?id=52340

[Build Bot]

Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16438276

[Zhenyao Mo]

This is awesome!  Thanks for doing this patch.

[Zhenyao Mo]

LGTM

[Kenneth Russell]

Comment on attachment 187070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187070&action=review

This will be great -- really looking forward to seeing this go in. The patch looks good overall. However, the patch for bug 52340, which this depends on, still has issues to be resolved, and has to land before the early warning system bots can properly process this patch. I'm marking this r- because it can't be properly reviewed yet. Please resubmit this patch and request review when the fix for bug 52340 has landed.

> Source/WebCore/ChangeLog:16
>          Look into possibilities of typedef in webkit idl files

The ChangeLog will need to be regenerated after the fix for bug 52340 lands.

[Andrey Adaikin]

Created attachment 188313 [details]
Patch

[Kenneth Russell]

Comment on attachment 188313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188313&action=review

This looks great. Thank you for pushing this through. It brings WebKit's IDL much closer to the real Web IDL for this spec. r=me

> Source/WebCore/html/canvas/WebGLRenderingContext.idl:540
>      [StrictTypeChecking] int          getAttribLocation(in WebGLProgram program, in DOMString name);

Is there some issue with changing this to return GLint? Could you file a bug to track this discrepancy?

[Andrey Adaikin]

(In reply to comment #17)
> (From update of attachment 188313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188313&action=review
> 
> This looks great. Thank you for pushing this through. It brings WebKit's IDL much closer to the real Web IDL for this spec. r=me
> 
> > Source/WebCore/html/canvas/WebGLRenderingContext.idl:540
> >      [StrictTypeChecking] int          getAttribLocation(in WebGLProgram program, in DOMString name);
> 
> Is there some issue with changing this to return GLint? Could you file a bug to track this discrepancy?

Filed https://bugs.webkit.org/show_bug.cgi?id=109892

[WebKit Review Bot]

Comment on attachment 188313 [details]
Patch

Clearing flags on attachment: 188313

Committed r142967: <http://trac.webkit.org/changeset/142967>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.