Summary: | Use GL typedefs in WebGLRenderingContext.idl | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Adaikin <aandrey> | ||||||
Component: | WebGL | Assignee: | Andrey Adaikin <aandrey> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, buildbot, dglazkov, dino, gtk-ews, kbr, ojan.autocc, peter+ews, pfeldman, rniwa, webkit-ews, webkit.review.bot, xan.lopez, zmo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 52340 | ||||||||
Bug Blocks: | 108649 | ||||||||
Attachments: |
|
Description
Andrey Adaikin
2013-02-06 08:58:08 PST
Created attachment 187070 [details]
Patch
Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16435138 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16438135 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16427122 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16430158 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16418164 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16428194 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16428180 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16415311 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16408383 Sorry for the bots warnings. This patch depends on https://bugs.webkit.org/show_bug.cgi?id=52340 Comment on attachment 187070 [details] Patch Attachment 187070 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16438276 This is awesome! Thanks for doing this patch. LGTM Comment on attachment 187070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187070&action=review This will be great -- really looking forward to seeing this go in. The patch looks good overall. However, the patch for bug 52340, which this depends on, still has issues to be resolved, and has to land before the early warning system bots can properly process this patch. I'm marking this r- because it can't be properly reviewed yet. Please resubmit this patch and request review when the fix for bug 52340 has landed. > Source/WebCore/ChangeLog:16 > Look into possibilities of typedef in webkit idl files The ChangeLog will need to be regenerated after the fix for bug 52340 lands. Created attachment 188313 [details]
Patch
Comment on attachment 188313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188313&action=review This looks great. Thank you for pushing this through. It brings WebKit's IDL much closer to the real Web IDL for this spec. r=me > Source/WebCore/html/canvas/WebGLRenderingContext.idl:540 > [StrictTypeChecking] int getAttribLocation(in WebGLProgram program, in DOMString name); Is there some issue with changing this to return GLint? Could you file a bug to track this discrepancy? (In reply to comment #17) > (From update of attachment 188313 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188313&action=review > > This looks great. Thank you for pushing this through. It brings WebKit's IDL much closer to the real Web IDL for this spec. r=me > > > Source/WebCore/html/canvas/WebGLRenderingContext.idl:540 > > [StrictTypeChecking] int getAttribLocation(in WebGLProgram program, in DOMString name); > > Is there some issue with changing this to return GLint? Could you file a bug to track this discrepancy? Filed https://bugs.webkit.org/show_bug.cgi?id=109892 Comment on attachment 188313 [details] Patch Clearing flags on attachment: 188313 Committed r142967: <http://trac.webkit.org/changeset/142967> All reviewed patches have been landed. Closing bug. |