Bug 108825

Summary:

[EFL][WK2] Use C API inside EwkView

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

WebKit2

Assignee:

Kenneth Rohde Christiansen <kenneth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, benjamin, cdumez, gyuyoung.kim, mikhail.pozdnyakov, rakuco, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

107657

Attachments:

Description	Flags
Patch	none

Description Kenneth Rohde Christiansen 2013-02-04 07:52:53 PST

SSIA

Comment 1 Kenneth Rohde Christiansen 2013-02-04 07:59:27 PST

Created attachment 186374 [details]
Patch

Comment 2 Mikhail Pozdnyakov 2013-02-04 08:27:06 PST

Comment on attachment 186374 [details]
Patch

LGTM

Comment 3 Chris Dumez 2013-02-04 08:33:16 PST

Comment on attachment 186374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186374&action=review

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:895
> +    WKRetainPtr<WKStringRef> wkURLString = wkActiveURL ? adoptWK(WKURLCopyString(wkActiveURL.get())) : adoptWK(WKStringCreateWithUTF8CString(""));

WKURLCopyString()?

Comment 4 Chris Dumez 2013-02-04 08:55:33 PST

Comment on attachment 186374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186374&action=review

>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:895
>> +    WKRetainPtr<WKStringRef> wkURLString = wkActiveURL ? adoptWK(WKURLCopyString(wkActiveURL.get())) : adoptWK(WKStringCreateWithUTF8CString(""));
> 
> WKURLCopyString()?

Never mind. You are already using it. I did not read properly sorry.

Comment 5 Chris Dumez 2013-02-04 09:00:17 PST

Oh, I forgot: LGTM :)

Comment 6 WebKit Review Bot 2013-02-04 15:59:12 PST

Comment on attachment 186374 [details]
Patch

Clearing flags on attachment: 186374

Committed r141827: <http://trac.webkit.org/changeset/141827>

Comment 7 WebKit Review Bot 2013-02-04 15:59:17 PST

All reviewed patches have been landed.  Closing bug.