| Summary: | Add support for -webkit-background-blend-mode to chromium | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rik Cabanier <cabanier> | ||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | junov, olaru, schenney, senorblanco, syoichi, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 108547, 111818, 113394 | ||||||
| Bug Blocks: | 108546 | ||||||
| Attachments: |
|
||||||
|
Description
Rik Cabanier
2013-01-31 16:53:02 PST
Created attachment 196107 [details]
Patch
I have taken the Skia blend mode enabling code from the latest patches in bug 100071, so one could say they are partially reviewed. Therefore, I'm not sure how we should go about this code. What is added on top of that is changes to ImageSkia to take into account the blend mode, and a new test that goes through Image::drawPattern (which did not get called otherwise). I also have a question. Skia relies on the SkPaint object to pass and read the blend/composite mode (setXfermodeMode). However, I noticed that the Image::draw* functions also receive a GraphicsContext object, which also has a reference to a PlatformGraphicsContext (returned by platformContext). For Skia, this is a PlatformContextSkia object. The GraphicsContext object has a setCompositeOperation function, which ultimately ends up calling the PlatformContextSkia::setXfermodeMode. However, I'm not sure if this xfer mode is ever actually read or used from somewhere, since the SkPaint object seems to be enough to pass in this mode to Skia. I feel like I should call setCompositeOperation, so that the Skia graphics context it is in sync with the SkPaint mode, in case someone reads it in the future, but I would like another opinion on it. Is this API only there to conform to the GraphicsContext API? Because setCompositeOperation seems to be redundant (at least for Skia), so I might be missing something. (In reply to comment #2) > I have taken the Skia blend mode enabling code from the latest patches in bug 100071, so one could say they are partially reviewed. Therefore, I'm not sure how we should go about this code. Since this is a patch for chromium and is blocked by 113394, you should add test results for that platform too. Comment on attachment 196107 [details]
Patch
Clearing flag for a Chromium-specific patch.
|