Bug 111818 - create runtime flags for CSS Compositing
Summary: create runtime flags for CSS Compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rik Cabanier
URL:
Keywords:
Depends on: 112333
Blocks: 108550
  Show dependency tree / graph
 
Reported: 2013-03-07 20:59 PST by Rik Cabanier
Modified: 2014-02-24 18:30 PST (History)
15 users (show)

See Also:

Attachments
not for review (11.65 KB, text/plain)
2013-03-07 21:11 PST, Rik Cabanier 		no flags Details
not for review (11.65 KB, patch)
2013-03-07 21:41 PST, Rik Cabanier 		no flags Details | Formatted Diff | Diff
patch (12.46 KB, patch)
2013-03-08 15:41 PST, Rik Cabanier 		no flags Details | Formatted Diff | Diff
Patch (22.57 KB, patch)
2013-03-13 15:00 PDT, Rik Cabanier 		no flags Details | Formatted Diff | Diff
Patch (22.57 KB, text/plain)
2013-03-13 15:55 PDT, Rik Cabanier 		no flags Details
Patch (22.46 KB, patch)
2013-03-13 16:15 PDT, Rik Cabanier 		no flags Details | Formatted Diff | Diff
Fixed style issue (22.46 KB, patch)
2013-03-13 20:07 PDT, Rik Cabanier 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Cabanier 2013-03-07 20:59:44 PST 
This patch will add flags to WebCore to turn CSS compositing and blending features off and on.
Comment 1 Rik Cabanier 2013-03-07 21:11:08 PST 
Created attachment 192140 [details]
not for review
Comment 2 WebKit Review Bot 2013-03-07 21:13:00 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Early Warning System Bot 2013-03-07 21:23:43 PST 
Comment on attachment 192140 [details]
not for review

Attachment 192140 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17021292
Comment 4 Early Warning System Bot 2013-03-07 21:27:09 PST 
Comment on attachment 192140 [details]
not for review

Attachment 192140 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17021293
Comment 5 Rik Cabanier 2013-03-07 21:41:07 PST 
Created attachment 192141 [details]
not for review
Comment 6 Early Warning System Bot 2013-03-07 21:50:06 PST 
Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17008402
Comment 7 Early Warning System Bot 2013-03-07 21:51:33 PST 
Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17066310
Comment 8 Build Bot 2013-03-07 22:37:17 PST 
Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16992546
Comment 9 Build Bot 2013-03-08 05:46:19 PST 
Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16997361
Comment 10 Build Bot 2013-03-08 08:32:05 PST 
Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17080104
Comment 11 Rik Cabanier 2013-03-08 15:41:40 PST 
Created attachment 192297 [details]
patch
Comment 12 Rik Cabanier 2013-03-13 15:00:30 PDT 
Created attachment 193002 [details]
Patch
Comment 13 Simon Fraser (smfr) 2013-03-13 15:32:31 PDT 
Comment on attachment 193002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193002&action=review

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:60
> +bool RuntimeEnabledFeatures::isSSCompositingEnabled = false;

Typo.
Comment 14 Rik Cabanier 2013-03-13 15:36:40 PDT 
(In reply to comment #13)
> (From update of attachment 193002 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193002&action=review
> 
> > Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:60
> > +bool RuntimeEnabledFeatures::isSSCompositingEnabled = false;
> 
> Typo.

Good catch!
Comment 15 Rik Cabanier 2013-03-13 15:55:34 PDT 
Created attachment 193014 [details]
Patch
Comment 16 Simon Fraser (smfr) 2013-03-13 16:02:25 PDT 
Comment on attachment 193014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193014&action=review

> Source/WebCore/ChangeLog:3
> +        create runtime flags for CSS Compositing

Create

> Source/WebCore/ChangeLog:10
> +        Added a runtime flags to enable CSS compositing as a runtime flag for chromium.

Is this really chromium-specific?
Comment 17 Rik Cabanier 2013-03-13 16:09:10 PDT 
(In reply to comment #16)
> (From update of attachment 193014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193014&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        create runtime flags for CSS Compositing
> 
> Create
> 
> > Source/WebCore/ChangeLog:10
> > +        Added a runtime flags to enable CSS compositing as a runtime flag for chromium.
> 
> Is this really chromium-specific?

Well, that's how the bug started out :-)
I guess it is now also a preference in Safari but it's always on by default.
Comment 18 Rik Cabanier 2013-03-13 16:10:26 PDT 
(In reply to comment #17)
> (In reply to comment #16)
> > (From update of attachment 193014 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=193014&action=review
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        create runtime flags for CSS Compositing
> > 
> > Create
> > 
> > > Source/WebCore/ChangeLog:10
> > > +        Added a runtime flags to enable CSS compositing as a runtime flag for chromium.
> > 
> > Is this really chromium-specific?
> 
> Well, that's how the bug started out :-)
> I guess it is now also a preference in Safari but it's always on by default.

I will update the changelog
Comment 19 Rik Cabanier 2013-03-13 16:15:37 PDT 
Created attachment 193018 [details]
Patch
Comment 20 Ryosuke Niwa 2013-03-13 20:04:12 PDT 
Comment on attachment 193018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193018&action=review

rs=me.

> Source/WebCore/css/CSSParser.cpp:4322
> +                    if (cssCompositingEnabled() &&(val->id == CSSValueNormal || val->id == CSSValueMultiply

Nit: space needed after &&.
Comment 21 Ryosuke Niwa 2013-03-13 20:04:56 PDT 
Comment on attachment 193018 [details]
Patch

cq- due to the nit.
Comment 22 Rik Cabanier 2013-03-13 20:07:20 PDT 
Created attachment 193049 [details]
Fixed style issue
Comment 23 WebKit Review Bot 2013-03-13 20:55:11 PDT 
Comment on attachment 193049 [details]
Fixed style issue

Clearing flags on attachment: 193049

Committed r145784: <http://trac.webkit.org/changeset/145784>
Comment 24 WebKit Review Bot 2013-03-13 20:55:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 25 Takahiro Ichihashi 2014-02-24 18:30:06 PST 
What version is expected to be landed with this patch?