Bug 111818 – create runtime flags for CSS Compositing

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rik Cabanier]

This patch will add flags to WebCore to turn CSS compositing and blending features off and on.

[Rik Cabanier]

Created attachment 192140 [details]
not for review

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Early Warning System Bot]

Comment on attachment 192140 [details]
not for review

Attachment 192140 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17021292

[Early Warning System Bot]

Comment on attachment 192140 [details]
not for review

Attachment 192140 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17021293

[Rik Cabanier]

Created attachment 192141 [details]
not for review

[Early Warning System Bot]

Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17008402

[Early Warning System Bot]

Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17066310

[Build Bot]

Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16992546

[Build Bot]

Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16997361

[Build Bot]

Comment on attachment 192141 [details]
not for review

Attachment 192141 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17080104

[Rik Cabanier]

Created attachment 192297 [details]
patch

[Rik Cabanier]

Created attachment 193002 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 193002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193002&action=review

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:60
> +bool RuntimeEnabledFeatures::isSSCompositingEnabled = false;

Typo.

[Rik Cabanier]

(In reply to comment #13)
> (From update of attachment 193002 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193002&action=review
> 
> > Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:60
> > +bool RuntimeEnabledFeatures::isSSCompositingEnabled = false;
> 
> Typo.

Good catch!

[Rik Cabanier]

Created attachment 193014 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 193014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193014&action=review

> Source/WebCore/ChangeLog:3
> +        create runtime flags for CSS Compositing

Create

> Source/WebCore/ChangeLog:10
> +        Added a runtime flags to enable CSS compositing as a runtime flag for chromium.

Is this really chromium-specific?

[Rik Cabanier]

(In reply to comment #16)
> (From update of attachment 193014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193014&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        create runtime flags for CSS Compositing
> 
> Create
> 
> > Source/WebCore/ChangeLog:10
> > +        Added a runtime flags to enable CSS compositing as a runtime flag for chromium.
> 
> Is this really chromium-specific?

Well, that's how the bug started out :-)
I guess it is now also a preference in Safari but it's always on by default.

[Rik Cabanier]

(In reply to comment #17)
> (In reply to comment #16)
> > (From update of attachment 193014 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=193014&action=review
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        create runtime flags for CSS Compositing
> > 
> > Create
> > 
> > > Source/WebCore/ChangeLog:10
> > > +        Added a runtime flags to enable CSS compositing as a runtime flag for chromium.
> > 
> > Is this really chromium-specific?
> 
> Well, that's how the bug started out :-)
> I guess it is now also a preference in Safari but it's always on by default.

I will update the changelog

[Rik Cabanier]

Created attachment 193018 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 193018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193018&action=review

rs=me.

> Source/WebCore/css/CSSParser.cpp:4322
> +                    if (cssCompositingEnabled() &&(val->id == CSSValueNormal || val->id == CSSValueMultiply

Nit: space needed after &&.

[Ryosuke Niwa]

Comment on attachment 193018 [details]
Patch

cq- due to the nit.

[Rik Cabanier]

Created attachment 193049 [details]
Fixed style issue

[WebKit Review Bot]

Comment on attachment 193049 [details]
Fixed style issue

Clearing flags on attachment: 193049

Committed r145784: <http://trac.webkit.org/changeset/145784>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Takahiro Ichihashi]

What version is expected to be landed with this patch?