Bug 108547

Summary: Add support for parsing of -webkit-background-blend-mode
Product: WebKit Reporter: Rik Cabanier <cabanier>
Component: CSSAssignee: Rik Cabanier <cabanier>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, dglazkov, eric, krit, macpherson, menard, ojan.autocc, rniwa, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108546, 108549, 108550, 108551    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
webkit-ews: commit-queue-
Patch none

Rik Cabanier
Reported 2013-01-31 16:32:17 PST
This patch will add support for the parsing of -webkit-background-blend-mode
Attachments
Patch (31.89 KB, patch)
2013-01-31 16:43 PST, Rik Cabanier 		no flags
DetailsFormatted DiffDiff
Patch (46.91 KB, patch)
2013-01-31 20:47 PST, Rik Cabanier 		no flags
DetailsFormatted DiffDiff
Patch (46.86 KB, text/plain)
2013-02-04 16:10 PST, Rik Cabanier 		no flags
Details
Patch (47.45 KB, text/plain)
2013-02-04 16:37 PST, Rik Cabanier 		webkit-ews: commit-queue-
Details
Patch (47.53 KB, patch)
2013-02-04 17:07 PST, Rik Cabanier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Rik Cabanier
Comment 1 2013-01-31 16:43:39 PST
Created attachment 185894 [details] Patch
WebKit Review Bot
Comment 2 2013-01-31 18:31:57 PST
Comment on attachment 185894 [details] Patch Attachment 185894 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16301170 New failing tests: css3/compositing/background-blend-mode-property-parsing.html css3/compositing/background-blend-mode-property.html
Rik Cabanier
Comment 3 2013-01-31 20:47:50 PST
Created attachment 185923 [details] Patch
Rik Cabanier
Comment 4 2013-02-04 13:10:55 PST
(In reply to comment #3) > Created an attachment (id=185923) [details] > Patch dhyatt reviewed and spotted bug in cssparser.cpp
Rik Cabanier
Comment 5 2013-02-04 16:10:47 PST
Created attachment 186489 [details] Patch
Rik Cabanier
Comment 6 2013-02-04 16:37:29 PST
Created attachment 186494 [details] Patch
Early Warning System Bot
Comment 7 2013-02-04 16:49:03 PST
Comment on attachment 186494 [details] Patch Attachment 186494 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16367473
Early Warning System Bot
Comment 8 2013-02-04 16:53:22 PST
Comment on attachment 186494 [details] Patch Attachment 186494 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16371488
Build Bot
Comment 9 2013-02-04 16:59:30 PST
Comment on attachment 186494 [details] Patch Attachment 186494 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16370436
Rik Cabanier
Comment 10 2013-02-04 17:07:49 PST
Created attachment 186503 [details] Patch
Dave Hyatt
Comment 11 2013-02-07 12:44:26 PST
Comment on attachment 186503 [details] Patch r=me, might consider pulling the property names check into a little static helper though.
WebKit Review Bot
Comment 12 2013-02-07 13:15:09 PST
Comment on attachment 186503 [details] Patch Clearing flags on attachment: 186503 Committed r142168: <http://trac.webkit.org/changeset/142168>
WebKit Review Bot
Comment 13 2013-02-07 13:15:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.