| Summary: | [chromium] Rework page scale factor limits initialization | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexandre Elias <aelias> | ||||
| Component: | New Bugs | Assignee: | Alexandre Elias <aelias> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, aelias, jamesr, klobag | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 107922 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Alexandre Elias
2013-01-31 02:26:33 PST
Created attachment 185727 [details]
Patch
Comment on attachment 185727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185727&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:3804 > + if (view && view->needsLayout()) > + view->layout(); Why doesn't this cause an infinite loop? Page scale factor limits are supposed to converge and it shouldn't set needsLayout() repeatedly. What I expect to cause a layout right now is fixed-position element positioning, and that doesn't affect the inputs of computePageScaleFactorLimits. If there's a bug and it doesn't converge, that would cause problems anyway and it's probably better to catch that issue via crash report than via reports of glitchniness or of very slow renderer due to repeated layout. Committed r141483: <http://trac.webkit.org/changeset/141483> |