Bug 108446

Summary: [chromium] Rework page scale factor limits initialization
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, jamesr, klobag
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107922    
Bug Blocks:    
Attachments:
Description Flags
Patch jamesr: review+

Alexandre Elias
Reported 2013-01-31 02:26:33 PST
[chromium] Rework page scale factor limits initialization
Attachments
Patch (21.30 KB, patch)
2013-01-31 02:38 PST, Alexandre Elias 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2013-01-31 02:38:21 PST
Created attachment 185727 [details] Patch
Adam Barth
Comment 2 2013-01-31 10:27:28 PST
Comment on attachment 185727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185727&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:3804 > + if (view && view->needsLayout()) > + view->layout(); Why doesn't this cause an infinite loop?
Alexandre Elias
Comment 3 2013-01-31 10:36:01 PST
Page scale factor limits are supposed to converge and it shouldn't set needsLayout() repeatedly. What I expect to cause a layout right now is fixed-position element positioning, and that doesn't affect the inputs of computePageScaleFactorLimits. If there's a bug and it doesn't converge, that would cause problems anyway and it's probably better to catch that issue via crash report than via reports of glitchniness or of very slow renderer due to repeated layout.
Alexandre Elias
Comment 4 2013-01-31 14:03:57 PST
Committed r141483: <http://trac.webkit.org/changeset/141483>
Note You need to log in before you can comment on or make changes to this bug.