Bug 108213

Summary:

[Qt] HTML5 video - sound volume bar out of widget

Product:

WebKit

Reporter:

jingdow

Component:

New Bugs

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, allan.jensen, cmarcelo, eric.carlson, feature-media-reviews, macpherson, menard, nowrep, ojan.autocc, pierre.rossi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

88186, 103747, 112146

Attachments:

Description	Flags
Patch	none
Fixes issue also for media files url's	none
Patch	none
Patch	jturcotte: review+

jingdow

Reported 2013-01-29 12:32:08 PST

Another regression since qtwebkit 2.2. Sound volume bar is often displaced and out of the video widget. Also, If browser supports directly opening of the media, after video plays to the end it disappears. Page for testing: http://www.w3schools.com/html/tryit.asp?filename=tryhtml5_video_all Some screenshots of the issue: 1. http://s7.postimage.org/kzo5oesaz/sbissue1.png 2. http://s1.postimage.org/h5isrnysf/sbissue2.png 3. http://s8.postimage.org/ncvzfjuzn/sbissue3.png Picture nr. 3 is the situation where the video would disappear after playing to the end.

Attachments
Patch (2.82 KB, patch) 2013-01-31 03:11 PST, Allan Sandfeld Jensen	no flags	Details Formatted Diff Diff
Fixes issue also for media files url's (2.33 KB, patch) 2013-01-31 04:54 PST, David Rosca	no flags	Details Formatted Diff Diff
Patch (3.58 KB, patch) 2013-02-18 03:03 PST, Allan Sandfeld Jensen	no flags	Details Formatted Diff Diff
Patch (9.38 KB, patch) 2013-02-18 10:09 PST, Allan Sandfeld Jensen	jturcotte: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Allan Sandfeld Jensen

Comment 1 2013-01-30 04:55:13 PST

This is not specific to QtWebKit 2.3. I can reproduce the same issue in trunk with Qt5.

Allan Sandfeld Jensen

Comment 2 2013-01-31 03:11:21 PST

Created attachment 185732 [details] Patch

David Rosca

Comment 3 2013-01-31 04:54:01 PST

Created attachment 185752 [details] Fixes issue also for media files url's

David Rosca

Comment 4 2013-01-31 04:54:20 PST

The patch doesn't fix the issue on: http://www.w3schools.com/html/movie.mp4 My patch fixes it.

jingdow

Comment 5 2013-01-31 06:03:13 PST

Confirming, David's patch fixed the sound volume bar.

Allan Sandfeld Jensen

Comment 6 2013-02-18 03:03:50 PST

Created attachment 188840 [details] Patch

Allan Sandfeld Jensen

Comment 7 2013-02-18 07:51:00 PST

Comment on attachment 188840 [details] Patch Untagging for review. The underlying issue seems to be we use the Apple MediaControl shadow DOM, but with our own CSS and set of buttons. All these patch attempts does is work around the wrong underlying shadow DOM tree.

Allan Sandfeld Jensen

Comment 8 2013-02-18 10:09:12 PST

Created attachment 188914 [details] Patch Another attempt, this time following Apple CSS, but keeping our style.

Jocelyn Turcotte

Comment 9 2013-03-08 05:02:10 PST

Comment on attachment 188914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188914&action=review I can't say that those coordinates all makes sense to me, but I tested the patch and it's definitely an improvement. > Source/WebCore/css/mediaControlsQt.css:39 > bottom: 0px; This line is already in mediaControls.css, you should be able to remove it.

Allan Sandfeld Jensen

Comment 10 2013-03-08 06:25:08 PST

Committed r145214: <http://trac.webkit.org/changeset/145214>

Note You need to log in before you can comment on or make changes to this bug.