Bug 108209

Summary: Refactor ShadowRoot exception handling
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: New BugsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, dglazkov, mifenton, morrita, ojan.autocc, ojan, peter+ews, rniwa, tkent, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108301    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Elliott Sprehn
Reported 2013-01-29 11:32:25 PST
Refactor ShadowRoot exception handling
Attachments
Patch (9.86 KB, patch)
2013-01-29 11:37 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (12.85 KB, patch)
2013-01-29 12:24 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (18.61 KB, patch)
2013-01-29 13:06 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (19.32 KB, patch)
2013-01-29 13:47 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (19.55 KB, patch)
2013-01-29 14:12 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (19.34 KB, patch)
2013-01-29 15:26 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2013-01-29 11:37:05 PST
Created attachment 185275 [details] Patch
Early Warning System Bot
Comment 2 2013-01-29 11:41:25 PST
Comment on attachment 185275 [details] Patch Attachment 185275 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16195241
Early Warning System Bot
Comment 3 2013-01-29 11:44:01 PST
Comment on attachment 185275 [details] Patch Attachment 185275 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16187316
EFL EWS Bot
Comment 4 2013-01-29 11:47:00 PST
Comment on attachment 185275 [details] Patch Attachment 185275 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16151309
WebKit Review Bot
Comment 5 2013-01-29 11:54:23 PST
Comment on attachment 185275 [details] Patch Attachment 185275 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16151315
Elliott Sprehn
Comment 6 2013-01-29 12:00:49 PST
Woops, it seems we do ShadowRoot::create in a bunch of places I missed.
Build Bot
Comment 7 2013-01-29 12:01:07 PST
Comment on attachment 185275 [details] Patch Attachment 185275 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16198259
Peter Beverloo (cr-android ews)
Comment 8 2013-01-29 12:03:38 PST
Comment on attachment 185275 [details] Patch Attachment 185275 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16200266
Build Bot
Comment 9 2013-01-29 12:11:19 PST
Comment on attachment 185275 [details] Patch Attachment 185275 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16202258
Elliott Sprehn
Comment 10 2013-01-29 12:24:53 PST
Created attachment 185283 [details] Patch
Elliott Sprehn
Comment 11 2013-01-29 12:26:22 PST
(In reply to comment #10) > Created an attachment (id=185283) [details] > Patch Fixed the build, should be good for review now.
Build Bot
Comment 12 2013-01-29 12:51:01 PST
Comment on attachment 185283 [details] Patch Attachment 185283 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16183293
Build Bot
Comment 13 2013-01-29 12:56:37 PST
Comment on attachment 185283 [details] Patch Attachment 185283 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16200292
Elliott Sprehn
Comment 14 2013-01-29 13:06:31 PST
Created attachment 185292 [details] Patch Exports, yay.
Build Bot
Comment 15 2013-01-29 13:36:35 PST
Comment on attachment 185292 [details] Patch Attachment 185292 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16183309
Build Bot
Comment 16 2013-01-29 13:43:32 PST
Comment on attachment 185292 [details] Patch Attachment 185292 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16198296
Elliott Sprehn
Comment 17 2013-01-29 13:47:52 PST
Created attachment 185300 [details] Patch More exporting.
Elliott Sprehn
Comment 18 2013-01-29 14:12:49 PST
Created attachment 185306 [details] Patch
Elliott Sprehn
Comment 19 2013-01-29 15:26:20 PST
Created attachment 185319 [details] Patch
WebKit Review Bot
Comment 20 2013-01-29 16:03:48 PST
Comment on attachment 185319 [details] Patch Clearing flags on attachment: 185319 Committed r141175: <http://trac.webkit.org/changeset/141175>
WebKit Review Bot
Comment 21 2013-01-29 16:03:55 PST
All reviewed patches have been landed. Closing bug.
Elliott Sprehn
Comment 22 2013-01-30 00:00:04 PST
Reading the code more closely it appears this patch should have broken TextFieldDecorationElement because it intended to actually create multiple user agent shadow roots!?? Unfortunately there's no layout tests for this code, in fact TextFieldDecorationElement is only used in ChromeClientImpl::addTextFieldDecorationsTo which seems really bad that we have magical elements and hacks in WebCore that are specifically for Chromium and then have no tests in WebCore for them.
Elliott Sprehn
Comment 23 2013-01-30 00:47:59 PST
(In reply to comment #22) > Reading the code more closely it appears this patch should have broken TextFieldDecorationElement because it intended to actually create multiple user agent shadow roots!?? > > Unfortunately there's no layout tests for this code, in fact TextFieldDecorationElement is only used in ChromeClientImpl::addTextFieldDecorationsTo which seems really bad that we have magical elements and hacks in WebCore that are specifically for Chromium and then have no tests in WebCore for them. https://bugs.webkit.org/show_bug.cgi?id=108301
Note You need to log in before you can comment on or make changes to this bug.