Bug 108055

Summary: [REGRESSION] Calendar Picker focus ring is gone
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: gavinp, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keishi Hattori
Reported 2013-01-27 23:51:23 PST
This is because -webkit-focus-ring-color is only allowed for outline property in strict mode.
Attachments
Patch (2.43 KB, patch)
2013-01-28 00:59 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2013-01-28 01:20 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (58.63 KB, patch)
2013-02-07 01:20 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2013-01-28 00:59:34 PST
Created attachment 184947 [details] Patch
Kent Tamura
Comment 2 2013-01-28 01:02:20 PST
Comment on attachment 184947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184947&action=review > Source/WebCore/ChangeLog:12 > + Can't reproduce in layout test. You had better add a reason.
Keishi Hattori
Comment 3 2013-01-28 01:20:07 PST
Created attachment 184950 [details] Patch
WebKit Review Bot
Comment 4 2013-01-28 01:40:46 PST
Comment on attachment 184950 [details] Patch Clearing flags on attachment: 184950 Committed r140955: <http://trac.webkit.org/changeset/140955>
WebKit Review Bot
Comment 5 2013-01-28 01:40:49 PST
All reviewed patches have been landed. Closing bug.
Keishi Hattori
Comment 6 2013-02-07 01:20:19 PST
Reopening to attach new patch.
Keishi Hattori
Comment 7 2013-02-07 01:20:22 PST
Created attachment 187020 [details] Patch
Kent Tamura
Comment 8 2013-02-07 01:48:30 PST
(In reply to comment #6) > Reopening to attach new patch. Did you post a patch to a wrong bug?
Keishi Hattori
Comment 9 2013-02-07 01:50:28 PST
Sorry my mistake.
Gavin Peters
Comment 10 2013-02-07 08:39:06 PST
Reverted r142111 for reason: win7 bot didn't display arabic Committed r142130: <http://trac.webkit.org/changeset/142130>
Gavin Peters
Comment 11 2013-02-07 09:12:40 PST
The win7 calendar lacked Arabic: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-required-ar.html , so I wan't comfortable rebaselining this myself.
Kent Tamura
Comment 12 2013-02-07 15:52:16 PST
gavin, this is a wrong bug. Let's move to Bug 109136
Note You need to log in before you can comment on or make changes to this bug.