Summary: | Call FrameView::contentsResized() when setting fixed layout size | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexandre Elias <aelias> | ||||||||||||||
Component: | New Bugs | Assignee: | Alexandre Elias <aelias> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abarth, hclam, jamesr, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 108120 | ||||||||||||||||
Bug Blocks: | 108446 | ||||||||||||||||
Attachments: |
|
Description
Alexandre Elias
2013-01-24 23:34:53 PST
Created attachment 184680 [details]
Patch
*** Bug 107206 has been marked as a duplicate of this bug. *** Who is the right person to review this change? Comment on attachment 184680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184680&action=review R=me. The WebCore changes seem quite reasonable. > Source/WebCore/platform/ScrollView.cpp:280 > + if (useFixedLayout()) nit: use m_useFixedLayout in ScrollView.cpp, like the rest of the file does Created attachment 184807 [details]
Patch
Fix nit
Comment on attachment 184807 [details] Patch Clearing flags on attachment: 184807 Committed r140869: <http://trac.webkit.org/changeset/140869> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 108120 Created attachment 185718 [details]
Patch
Created attachment 185724 [details]
Patch
Relanding as WebCore changes are identical. Created attachment 185728 [details]
Patch for landing
Comment on attachment 185728 [details] Patch for landing Rejecting attachment 185728 [details] from commit-queue. New failing tests: media/track/track-cues-enter-exit.html media/track/track-cues-cuechange.html Full output: http://queues.webkit.org/results/16280133 Created attachment 185808 [details]
Patch for landing
Comment on attachment 185808 [details] Patch for landing Clearing flags on attachment: 185808 Committed r141450: <http://trac.webkit.org/changeset/141450> All reviewed patches have been landed. Closing bug. |