Bug 107922

Summary: Call FrameView::contentsResized() when setting fixed layout size
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, hclam, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 108120    
Bug Blocks: 108446    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Alexandre Elias
Reported 2013-01-24 23:34:53 PST
Call FrameView::contentResized() when setting fixed layout size
Attachments
Patch (7.05 KB, patch)
2013-01-24 23:40 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (7.05 KB, patch)
2013-01-25 13:59 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (5.54 KB, patch)
2013-01-31 01:53 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (20.45 KB, patch)
2013-01-31 02:19 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.45 KB, patch)
2013-01-31 02:48 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.45 KB, patch)
2013-01-31 10:37 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2013-01-24 23:40:33 PST
Created attachment 184680 [details] Patch
Alexandre Elias
Comment 2 2013-01-24 23:45:22 PST
*** Bug 107206 has been marked as a duplicate of this bug. ***
Adam Barth
Comment 3 2013-01-25 09:23:05 PST
Who is the right person to review this change?
James Robinson
Comment 4 2013-01-25 10:29:29 PST
Comment on attachment 184680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184680&action=review R=me. The WebCore changes seem quite reasonable. > Source/WebCore/platform/ScrollView.cpp:280 > + if (useFixedLayout()) nit: use m_useFixedLayout in ScrollView.cpp, like the rest of the file does
Alexandre Elias
Comment 5 2013-01-25 13:59:21 PST
Created attachment 184807 [details] Patch Fix nit
WebKit Review Bot
Comment 6 2013-01-25 15:03:56 PST
Comment on attachment 184807 [details] Patch Clearing flags on attachment: 184807 Committed r140869: <http://trac.webkit.org/changeset/140869>
WebKit Review Bot
Comment 7 2013-01-25 15:04:00 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2013-01-28 15:02:17 PST
Re-opened since this is blocked by bug 108120
Alexandre Elias
Comment 9 2013-01-31 01:53:57 PST
Created attachment 185718 [details] Patch
Alexandre Elias
Comment 10 2013-01-31 02:19:17 PST
Created attachment 185724 [details] Patch
Alexandre Elias
Comment 11 2013-01-31 02:46:41 PST
Relanding as WebCore changes are identical.
Alexandre Elias
Comment 12 2013-01-31 02:48:20 PST
Created attachment 185728 [details] Patch for landing
WebKit Review Bot
Comment 13 2013-01-31 04:11:35 PST
Comment on attachment 185728 [details] Patch for landing Rejecting attachment 185728 [details] from commit-queue. New failing tests: media/track/track-cues-enter-exit.html media/track/track-cues-cuechange.html Full output: http://queues.webkit.org/results/16280133
Alexandre Elias
Comment 14 2013-01-31 10:37:18 PST
Created attachment 185808 [details] Patch for landing
WebKit Review Bot
Comment 15 2013-01-31 11:27:15 PST
Comment on attachment 185808 [details] Patch for landing Clearing flags on attachment: 185808 Committed r141450: <http://trac.webkit.org/changeset/141450>
WebKit Review Bot
Comment 16 2013-01-31 11:27:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.