Summary: | Support language WebVTT Nodes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dima Gorbik <dgorbik> | ||||||
Component: | Media | Assignee: | Dima Gorbik <dgorbik> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dgorbik, eric.carlson, feature-media-reviews, koivisto, ojan.autocc, silviapf, webkit-bug-importer, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 43668 | ||||||||
Attachments: |
|
Description
Dima Gorbik
2013-01-24 20:41:12 PST
Created attachment 184651 [details]
Proposed fix 0.1
Comment on attachment 184651 [details] Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=184651&action=review > Source/WebCore/html/track/WebVTTParser.cpp:345 > +inline bool isLangToken(WebVTTToken& token) static inline > Source/WebCore/html/track/WebVTTParser.h:136 > + Vector<AtomicString> languageStack; m_languageStack Created attachment 184822 [details]
Proposed fix 0.2
Comment on attachment 184822 [details]
Proposed fix 0.2
Marking r+ based on antti's earlier review.
Comment on attachment 184822 [details] Proposed fix 0.2 Clearing flags on attachment: 184822 Committed r140877: <http://trac.webkit.org/changeset/140877> All reviewed patches have been landed. Closing bug. |