Bug 107907

Summary: Support language WebVTT Nodes
Product: WebKit Reporter: Dima Gorbik <dgorbik>
Component: MediaAssignee: Dima Gorbik <dgorbik>
Status: RESOLVED FIXED    
Severity: Normal CC: dgorbik, eric.carlson, feature-media-reviews, koivisto, ojan.autocc, silviapf, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 43668    
Attachments:
Description Flags
Proposed fix 0.1
koivisto: review+
Proposed fix 0.2 none

Dima Gorbik
Reported 2013-01-24 20:41:12 PST
Language WebVTT nodes are used to define a language for children objects without implying further meaning (such as italics or bold)
Attachments
Proposed fix 0.1 (10.94 KB, patch)
2013-01-24 21:00 PST, Dima Gorbik 		koivisto: review+
DetailsFormatted DiffDiff
Proposed fix 0.2 (11.00 KB, patch)
2013-01-25 15:46 PST, Dima Gorbik 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-01-24 20:59:00 PST
<rdar://problem/13084183>
Radar WebKit Bug Importer
Comment 2 2013-01-24 20:59:03 PST
<rdar://problem/13084184>
Dima Gorbik
Comment 3 2013-01-24 21:00:00 PST
Created attachment 184651 [details] Proposed fix 0.1
Antti Koivisto
Comment 4 2013-01-25 01:59:43 PST
Comment on attachment 184651 [details] Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=184651&action=review > Source/WebCore/html/track/WebVTTParser.cpp:345 > +inline bool isLangToken(WebVTTToken& token) static inline > Source/WebCore/html/track/WebVTTParser.h:136 > + Vector<AtomicString> languageStack; m_languageStack
Dima Gorbik
Comment 5 2013-01-25 15:46:06 PST
Created attachment 184822 [details] Proposed fix 0.2
Eric Carlson
Comment 6 2013-01-25 16:06:52 PST
Comment on attachment 184822 [details] Proposed fix 0.2 Marking r+ based on antti's earlier review.
WebKit Review Bot
Comment 7 2013-01-25 16:22:17 PST
Comment on attachment 184822 [details] Proposed fix 0.2 Clearing flags on attachment: 184822 Committed r140877: <http://trac.webkit.org/changeset/140877>
WebKit Review Bot
Comment 8 2013-01-25 16:22:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.