Bug 107826

Summary: [EFL][WK2] Use C API inside ewk_url_response
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107657    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kenneth Rohde Christiansen
Reported 2013-01-24 07:29:57 PST
SSIA
Attachments
Patch (5.50 KB, patch)
2013-01-24 07:32 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (5.69 KB, patch)
2013-01-24 07:58 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (5.69 KB, patch)
2013-01-24 08:16 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2013-01-24 07:32:28 PST
Created attachment 184490 [details] Patch
Chris Dumez
Comment 2 2013-01-24 07:45:33 PST
Comment on attachment 184490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184490&action=review > Source/WebKit2/UIProcess/API/efl/ewk_url_response_private.h:-58 > - explicit EwkUrlResponse(const WebCore::ResourceResponse& coreResponse); We should probably stop including <WebCore/ResourceResponse.h> then.
Kenneth Rohde Christiansen
Comment 3 2013-01-24 07:58:34 PST
Created attachment 184496 [details] Patch
Chris Dumez
Comment 4 2013-01-24 08:04:31 PST
Comment on attachment 184496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184496&action=review > Source/WebKit2/Shared/API/c/WKURLResponse.h:47 > +WK_EXPORT uint32_t WKURLResponseGetExpectedContentsLength(WKURLResponseRef); Sorry I did not see this earlier but why contents (plural)? The HTTP header field is "Content-Length" (singular). Also note that WebCore and the EFL API both use Content (singular).
Kenneth Rohde Christiansen
Comment 5 2013-01-24 08:13:24 PST
(In reply to comment #4) > (From update of attachment 184496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184496&action=review > > > Source/WebKit2/Shared/API/c/WKURLResponse.h:47 > > +WK_EXPORT uint32_t WKURLResponseGetExpectedContentsLength(WKURLResponseRef); > > Sorry I did not see this earlier but why contents (plural)? The HTTP header field is "Content-Length" (singular). Also note that WebCore and the EFL API both use Content (singular). I will change it to that... contents vs content is something I never get right :-) and I am not the only one if you grep for those in WebKit!
Kenneth Rohde Christiansen
Comment 6 2013-01-24 08:16:37 PST
Created attachment 184504 [details] Patch
Mikhail Pozdnyakov
Comment 7 2013-01-24 12:20:26 PST
Comment on attachment 184504 [details] Patch LGTM
Andreas Kling
Comment 8 2013-01-28 02:16:17 PST
Comment on attachment 184504 [details] Patch r=me
WebKit Review Bot
Comment 9 2013-01-28 02:33:23 PST
Comment on attachment 184504 [details] Patch Clearing flags on attachment: 184504 Committed r140962: <http://trac.webkit.org/changeset/140962>
WebKit Review Bot
Comment 10 2013-01-28 02:33:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.