Bug 107826

Summary: [EFL][WK2] Use C API inside ewk_url_response
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107657    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Kenneth Rohde Christiansen 2013-01-24 07:29:57 PST 
SSIA
Comment 1 Kenneth Rohde Christiansen 2013-01-24 07:32:28 PST 
Created attachment 184490 [details]
Patch
Comment 2 Chris Dumez 2013-01-24 07:45:33 PST 
Comment on attachment 184490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184490&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_url_response_private.h:-58
> -    explicit EwkUrlResponse(const WebCore::ResourceResponse& coreResponse);

We should probably stop including <WebCore/ResourceResponse.h> then.
Comment 3 Kenneth Rohde Christiansen 2013-01-24 07:58:34 PST 
Created attachment 184496 [details]
Patch
Comment 4 Chris Dumez 2013-01-24 08:04:31 PST 
Comment on attachment 184496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184496&action=review

> Source/WebKit2/Shared/API/c/WKURLResponse.h:47
> +WK_EXPORT uint32_t WKURLResponseGetExpectedContentsLength(WKURLResponseRef);

Sorry I did not see this earlier but why contents (plural)?  The HTTP header field is "Content-Length" (singular). Also note that WebCore and the EFL API both use Content (singular).
Comment 5 Kenneth Rohde Christiansen 2013-01-24 08:13:24 PST 
(In reply to comment #4)
> (From update of attachment 184496 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184496&action=review
> 
> > Source/WebKit2/Shared/API/c/WKURLResponse.h:47
> > +WK_EXPORT uint32_t WKURLResponseGetExpectedContentsLength(WKURLResponseRef);
> 
> Sorry I did not see this earlier but why contents (plural)?  The HTTP header field is "Content-Length" (singular). Also note that WebCore and the EFL API both use Content (singular).

I will change it to that... contents vs content is something I never get right :-) and I am not the only one if you grep for those in WebKit!
Comment 6 Kenneth Rohde Christiansen 2013-01-24 08:16:37 PST 
Created attachment 184504 [details]
Patch
Comment 7 Mikhail Pozdnyakov 2013-01-24 12:20:26 PST 
Comment on attachment 184504 [details]
Patch

LGTM
Comment 8 Andreas Kling 2013-01-28 02:16:17 PST 
Comment on attachment 184504 [details]
Patch

r=me
Comment 9 WebKit Review Bot 2013-01-28 02:33:23 PST 
Comment on attachment 184504 [details]
Patch

Clearing flags on attachment: 184504

Committed r140962: <http://trac.webkit.org/changeset/140962>
Comment 10 WebKit Review Bot 2013-01-28 02:33:28 PST 
All reviewed patches have been landed.  Closing bug.