Bug 107660

Summary:

[GTK][WK2] Tests related to layoutTestController.setViewModeMediaFeature are passing

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

cgarcia, mrobinson, pnormand, webkit.review.bot, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Manuel Rego Casasnovas 2013-01-23 03:52:11 PST

However, they're marked as Failure at LayoutTests/platform/gtk-wk2/TestExpectations:

# Implement layoutTestController.setViewModeMediaFeature support 
Bug(GTK) fast/media/media-query-list-02.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-03.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-04.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-05.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-06.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-07.html [ Failure ] 
Bug(GTK) fast/media/view-mode-media-feature.html [ Failure ]

Comment 1 Manuel Rego Casasnovas 2013-01-23 03:57:41 PST

layoutTestController.setViewModeMediaFeature was implemented in bug #103886

http://trac.webkit.org/changeset/137148

Comment 2 Manuel Rego Casasnovas 2013-01-23 03:58:31 PST

Created attachment 184196 [details]
Patch

Comment 3 WebKit Review Bot 2013-01-23 10:50:02 PST

Comment on attachment 184196 [details]
Patch

Clearing flags on attachment: 184196

Committed r140550: <http://trac.webkit.org/changeset/140550>

Comment 4 WebKit Review Bot 2013-01-23 10:50:06 PST

All reviewed patches have been landed.  Closing bug.