Bug 107574

Summary: style-bot should reject Committer additions to committers.py
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alancutter, ap, commit-queue, dbates, dpranke, galpeter, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Checks for modification of contributors.json
none
Checks for modification of contributors.json on bots.
none
patch adds contributors.json style checker. none

Eric Seidel (no email)
Reported 2013-01-22 11:12:56 PST
style-bot should reject Committer additions to committers.py This comes up rather frequently with everyone using the CQ these days, no one actually knows (or really needs to know) how to commit. But it remains important to do your first commit yourself, to prove that Apple actually received, acknowledged your contract with them, and blessed your account. bug 107546 is the most recent example. Should be very easy to do.
Attachments
Checks for modification of contributors.json (16.15 KB, patch)
2013-11-08 04:12 PST, Tamas Gergely 		no flags
DetailsFormatted DiffDiff
Checks for modification of contributors.json on bots. (16.10 KB, patch)
2013-11-11 02:07 PST, Tamas Gergely 		no flags
DetailsFormatted DiffDiff
patch adds contributors.json style checker. (16.05 KB, patch)
2013-12-03 03:26 PST, Tamas Gergely 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-01-22 14:17:01 PST
Good idea!
Tamas Gergely
Comment 2 2013-11-08 04:12:58 PST
Created attachment 216374 [details] Checks for modification of contributors.json The listing of contributors seems to be changed since this bug had been reported. Now the list is in the contributors.json file. I attached a first-version patch, could you please comment it?
Peter Gal
Comment 3 2013-11-08 08:52:42 PST
Comment on attachment 216374 [details] Checks for modification of contributors.json View in context: https://bugs.webkit.org/attachment.cgi?id=216374&action=review > Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:57 > +# if _called_from_bot: I don't think this line is needed :)
Peter Gal
Comment 4 2013-11-08 08:54:14 PST
(In reply to comment #2) > I attached a first-version patch, could you please comment it? Maybe adding r? && cq? would be good.
Tamas Gergely
Comment 5 2013-11-11 02:07:47 PST
Created attachment 216554 [details] Checks for modification of contributors.json on bots.
Peter Gal
Comment 6 2013-11-21 00:53:44 PST
LGTM
Tamas Gergely
Comment 7 2013-12-03 03:26:30 PST
Created attachment 218284 [details] patch adds contributors.json style checker. Patch updated.
Zoltan Herczeg
Comment 8 2013-12-04 02:39:48 PST
Comment on attachment 218284 [details] patch adds contributors.json style checker. r=me Nice feature!
WebKit Commit Bot
Comment 9 2013-12-04 03:06:07 PST
Comment on attachment 218284 [details] patch adds contributors.json style checker. Clearing flags on attachment: 218284 Committed r160083: <http://trac.webkit.org/changeset/160083>
WebKit Commit Bot
Comment 10 2013-12-04 03:06:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.