Summary: | [GTK] [WTR] layoutTestController.pathToLocalResource needs to be updated | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, mrobinson, pnormand, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 107541 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2013-01-22 02:45:39 PST
Also these 2 extra tests were failing due to the same issue: * fast/dom/frame-loading-via-document-write.html (bug #64135) * http/tests/security/local-user-CSS-from-remote.html (bug #95043) Created attachment 183953 [details]
Patch
Comment on attachment 183953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183953&action=review Nice work. This looks good to me. I have just pointed out a style nit below. If you like, I can fix this and land it or you can upload a new patch. > Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:35 > #include "InjectedBundle.h" > + > +#include "InjectedBundleUtilities.h" > + > #include <glib.h> > +#include <wtf/gobject/GOwnPtr.h> Keep all these includes together as one solid block. (In reply to comment #3) > Nice work. This looks good to me. I have just pointed out a style nit below. If you like, I can fix this and land it or you can upload a new patch. I'll fix the issue in a new patch. Thanks for the review :-) Created attachment 184986 [details]
Patch
Comment on attachment 184986 [details] Patch Clearing flags on attachment: 184986 Committed r140970: <http://trac.webkit.org/changeset/140970> All reviewed patches have been landed. Closing bug. |