Bug 107210

Summary: REGRESSION(r140051): html-parser-srcdoc.html failing on Chromium Linux Perf and Chromium Mac Perf with a lot of error spew about blocked script execution in 'about:srcdoc' (Requested by dominicc on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc, eric, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107158    
Attachments:
Description Flags
ROLLOUT of r140051 none

WebKit Review Bot
Reported 2013-01-17 17:55:54 PST
http://trac.webkit.org/changeset/140051 broke the build: html-parser-srcdoc.html failing on Chromium Linux Perf and Chromium Mac Perf with a lot of error spew about blocked script execution in 'about:srcdoc' (Requested by dominicc on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r140051 (2.86 KB, patch)
2013-01-17 17:56 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2013-01-17 17:56:25 PST
Created attachment 183332 [details] ROLLOUT of r140051 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Dominic Cooney
Comment 2 2013-01-17 17:59:34 PST
Comment on attachment 183332 [details] ROLLOUT of r140051 Clearing flags on attachment: 183332 Committed r140078: <http://trac.webkit.org/changeset/140078>
Dominic Cooney
Comment 3 2013-01-17 17:59:38 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 4 2013-01-17 18:05:25 PST
Rolling out this patch wasn't the correct resolution to this bug. The test should just have been skipped.
Eric Seidel (no email)
Comment 5 2013-01-17 18:40:58 PST
The test was skipped... Did I mispell the name in the Skipped list?
Eric Seidel (no email)
Comment 6 2013-01-17 18:41:45 PST
I see. I missed the case of "Parser".
Eric Seidel (no email)
Comment 7 2013-01-17 18:43:36 PST
Btw, run-perf-test is kinda silly and requires you to edit a python file in order to ignore the console.log spew from a test so that it "passes". :) I just didn't bother to do so for this test.
Dominic Cooney
Comment 8 2013-01-17 19:02:37 PST
My apologies. I re-landed this in r140088 and will watch the bots.
Eric Seidel (no email)
Comment 9 2013-01-17 19:08:41 PST
np. I appreciate you "doing your job". :)
Note You need to log in before you can comment on or make changes to this bug.