Summary: | Web Inspector: [Canvas] introduce Resource.toDataURL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Adaikin <aandrey> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Adaikin <aandrey> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 107274 | ||||||
Attachments: |
|
Description
Andrey Adaikin
2013-01-16 08:47:50 PST
Created attachment 182992 [details]
Patch
Comment on attachment 182992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182992&action=review > Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:-2957 > - if (!this._traceLogPlayer || this._traceLogPlayer.traceLog() !== traceLog) { Why did this code go? > Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:-2994 > - _onTraceLogPlayerReset: function() ditto Comment on attachment 182992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182992&action=review >> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:-2957 >> - if (!this._traceLogPlayer || this._traceLogPlayer.traceLog() !== traceLog) { > > Why did this code go? Now these players are stored in the this._traceLogPlayers map, and we will support replaying all trace logs simultaneously (while before we kept only last player that was touched). This change is needed because we will expose replayed resources state (like current screenshot of a canvas, and etc.), which are bound to a "replay world". >> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:-2994 >> - _onTraceLogPlayerReset: function() > > ditto This is not needed any more, everything is encapsulated in the Player. Comment on attachment 182992 [details] Patch Clearing flags on attachment: 182992 Committed r140142: <http://trac.webkit.org/changeset/140142> All reviewed patches have been landed. Closing bug. |