| Summary: | Get WebCore compiling in VS2010 (32 bit) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||
| Component: | Platform | Assignee: | Roger Fong <roger_fong> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, jonlee, roger_fong, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Bug Depends on: | 106987 | ||||||||
| Bug Blocks: | 106949, 106989 | ||||||||
| Attachments: |
|
||||||||
|
Description
Roger Fong
2013-01-16 01:18:06 PST
Done, will start uploading changes thus far. Created attachment 183642 [details]
WebCore property sheets, project files and modified buildscripts
Also removed a forwarding headers directory that was empty/not being used anymore.
Could I can an r? Thanks Comment on attachment 183642 [details] WebCore property sheets, project files and modified buildscripts View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review rs=me. I do think it would be better to use "WebCore.vcxproj" as the directory name. > ChangeLog:8 > + * ForwardingHeaders/wtf: Removed. Did you actually remove ForwardingHeaders subdirectories? Why? The patch doesn't seem to do anything to these guys. > ChangeLog:15 > + * WebCore.vcproj/WebCore.sln: How about putting this solution file in WebCore.vcxproj, so that it does not clobber the VS2005 version? > ChangeLog:16 > + * WebCore2010.vcproj: Added. How about WebCore.vcxproj instead of WebCore2010? (In reply to comment #5) > (From update of attachment 183642 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review > > rs=me. I do think it would be better to use "WebCore.vcxproj" as the directory name. > > > ChangeLog:8 > > + * ForwardingHeaders/wtf: Removed. > > Did you actually remove ForwardingHeaders subdirectories? Why? The patch doesn't seem to do anything to these guys. mm yeah, i should probably stick that in a separate patch. It's just an unused subdirectory. I'll remove that from the patch. > > > ChangeLog:15 > > + * WebCore.vcproj/WebCore.sln: > > How about putting this solution file in WebCore.vcxproj, so that it does not clobber the VS2005 version? I think that's an accidental change. I don't think I even made a VS2010 WebCore solution itself. Do we need a solution specifically for WebCore? > > ChangeLog:16 > > + * WebCore2010.vcproj: Added. > > How about WebCore.vcxproj instead of WebCore2010? Oops, changed that, guess that's an old patch. Created attachment 184620 [details]
Updated WebCore property sheets and WebCore solution file
|