Bug 106988

Summary: Get WebCore compiling in VS2010 (32 bit)
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: PlatformAssignee: Roger Fong <roger_fong>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jonlee, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on: 106987    
Bug Blocks: 106949, 106989    
Attachments:
Description Flags
WebCore property sheets, project files and modified buildscripts
bfulgham: review+, bfulgham: commit-queue-
Updated WebCore property sheets and WebCore solution file none

Roger Fong
Reported 2013-01-16 01:18:06 PST
This includes WebCore, WebCoreGenerated and QTMovieWin.
Attachments
WebCore property sheets, project files and modified buildscripts (1.31 MB, patch)
2013-01-19 15:47 PST, Roger Fong 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
Updated WebCore property sheets and WebCore solution file (9.74 KB, patch)
2013-01-24 17:41 PST, Roger Fong 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-01-16 01:18:43 PST
<rdar://problem/13022798>
Roger Fong
Comment 2 2013-01-17 18:46:40 PST
Done, will start uploading changes thus far.
Roger Fong
Comment 3 2013-01-19 15:47:19 PST
Created attachment 183642 [details] WebCore property sheets, project files and modified buildscripts Also removed a forwarding headers directory that was empty/not being used anymore.
Roger Fong
Comment 4 2013-01-23 11:34:05 PST
Could I can an r? Thanks
Brent Fulgham
Comment 5 2013-01-23 12:03:04 PST
Comment on attachment 183642 [details] WebCore property sheets, project files and modified buildscripts View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review rs=me. I do think it would be better to use "WebCore.vcxproj" as the directory name. > ChangeLog:8 > + * ForwardingHeaders/wtf: Removed. Did you actually remove ForwardingHeaders subdirectories? Why? The patch doesn't seem to do anything to these guys. > ChangeLog:15 > + * WebCore.vcproj/WebCore.sln: How about putting this solution file in WebCore.vcxproj, so that it does not clobber the VS2005 version? > ChangeLog:16 > + * WebCore2010.vcproj: Added. How about WebCore.vcxproj instead of WebCore2010?
Roger Fong
Comment 6 2013-01-23 12:06:56 PST
(In reply to comment #5) > (From update of attachment 183642 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review > > rs=me. I do think it would be better to use "WebCore.vcxproj" as the directory name. > > > ChangeLog:8 > > + * ForwardingHeaders/wtf: Removed. > > Did you actually remove ForwardingHeaders subdirectories? Why? The patch doesn't seem to do anything to these guys. mm yeah, i should probably stick that in a separate patch. It's just an unused subdirectory. I'll remove that from the patch. > > > ChangeLog:15 > > + * WebCore.vcproj/WebCore.sln: > > How about putting this solution file in WebCore.vcxproj, so that it does not clobber the VS2005 version? I think that's an accidental change. I don't think I even made a VS2010 WebCore solution itself. Do we need a solution specifically for WebCore? > > ChangeLog:16 > > + * WebCore2010.vcproj: Added. > > How about WebCore.vcxproj instead of WebCore2010? Oops, changed that, guess that's an old patch.
Roger Fong
Comment 7 2013-01-24 17:41:58 PST
Created attachment 184620 [details] Updated WebCore property sheets and WebCore solution file
Note You need to log in before you can comment on or make changes to this bug.