Bug 106970

Summary: REGRESSION(r139792): Broke the windows build.
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: New BugsAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jochen, noel.gordon
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106904    
Attachments:
Description Flags
ROLLOUT of r139792 none

Levi Weintraub
Reported 2013-01-15 18:37:09 PST
http://trac.webkit.org/changeset/139792 broke the build: Broke the windows build.
Attachments
ROLLOUT of r139792 (24.36 KB, patch)
2013-01-15 18:37 PST, Levi Weintraub
no flags
Levi Weintraub
Comment 1 2013-01-15 18:37:26 PST
Created attachment 182897 [details] ROLLOUT of r139792 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Levi Weintraub
Comment 2 2013-01-15 18:40:31 PST
Comment on attachment 182897 [details] ROLLOUT of r139792 Clearing flags on attachment: 182897 Committed r139821: <http://trac.webkit.org/changeset/139821>
Levi Weintraub
Comment 3 2013-01-15 18:40:33 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 4 2013-01-15 19:00:12 PST
e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1107) : error C2079: 'tempPath' uses undefined class 'WTF::OwnArrayPtr<T>' with [ T=WCHAR ] e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1107) : error C3861: 'adoptArrayPtr': identifier not found e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1108) : error C2228: left of '.get' must have class/struct/union type is 'int' e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1111) : error C3861: 'adoptArrayPtr': identifier not found e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1112) : error C2228: left of '.get' must have class/struct/union type is 'int' e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1115) : error C2228: left of '.get' must have class/struct/union type is 'int' e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1115) : error C2228: left of '.utf8' must have class/struct/union ninja: build stopped: subcommand failed.
Note You need to log in before you can comment on or make changes to this bug.