Bug 106904

Summary: [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, leviw, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 106970    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch none

jochen
Reported 2013-01-15 07:12:44 PST
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
Attachments
Patch (24.76 KB, patch)
2013-01-15 07:13 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (24.78 KB, patch)
2013-01-15 07:29 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (24.78 KB, patch)
2013-01-15 07:36 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (24.78 KB, patch)
2013-01-15 07:41 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.88 KB, patch)
2013-01-15 13:49 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (25.04 KB, patch)
2013-01-16 03:57 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-01-15 07:13:21 PST
Created attachment 182760 [details] Patch
WebKit Review Bot
Comment 2 2013-01-15 07:16:25 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Peter Beverloo (cr-android ews)
Comment 3 2013-01-15 07:24:46 PST
Comment on attachment 182760 [details] Patch Attachment 182760 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15868896
jochen
Comment 4 2013-01-15 07:29:47 PST
Created attachment 182767 [details] Patch
Peter Beverloo (cr-android ews)
Comment 5 2013-01-15 07:34:10 PST
Comment on attachment 182767 [details] Patch Attachment 182767 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15845959
jochen
Comment 6 2013-01-15 07:36:07 PST
Created attachment 182769 [details] Patch
WebKit Review Bot
Comment 7 2013-01-15 07:37:43 PST
Attachment 182769 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/c..." exit_code: 1 Tools/DumpRenderTree/chromium/WebViewHost.cpp:73: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
jochen
Comment 8 2013-01-15 07:41:23 PST
Created attachment 182770 [details] Patch
jochen
Comment 9 2013-01-15 13:49:33 PST
Created attachment 182842 [details] Patch for landing
WebKit Review Bot
Comment 10 2013-01-15 14:23:10 PST
Comment on attachment 182842 [details] Patch for landing Clearing flags on attachment: 182842 Committed r139792: <http://trac.webkit.org/changeset/139792>
WebKit Review Bot
Comment 11 2013-01-15 14:23:14 PST
All reviewed patches have been landed. Closing bug.
Levi Weintraub
Comment 12 2013-01-15 18:37:12 PST
Re-opened since this is blocked by bug 106970
jochen
Comment 13 2013-01-16 03:57:00 PST
Created attachment 182954 [details] Patch
WebKit Review Bot
Comment 14 2013-01-16 04:43:12 PST
Comment on attachment 182954 [details] Patch Clearing flags on attachment: 182954 Committed r139872: <http://trac.webkit.org/changeset/139872>
WebKit Review Bot
Comment 15 2013-01-16 04:43:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.