Bug 106877

Summary:

Merge SVGStylable into SVGStyledElement

Product:

WebKit

Reporter:

Philip Rogers <pdr>

Component:

SVG

Assignee:

Philip Rogers <pdr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, buildbot, d-r, fmalita, gyuyoung.kim, haraken, japhet, krit, ojan.autocc, philn, rakuco, rniwa, schenney, webkit-ews, webkit.review.bot, xan.lopez, zimmermann

Priority:

Version:

420+

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

107386

Attachments:

Description	Flags
First pass - still need to fix a couple build files.	webkit-ews: commit-queue-
Update all build systems	webkit-ews: commit-queue-
Add a ChangeLog entry somebody forgot	webkit-ews: commit-queue-
Update DerivedSources for QT EWS happiness.	none

Philip Rogers

Reported 2013-01-14 23:40:53 PST

SVG2 changes element inheritance so all SVGElements are stylable. As a first-step towards a cleaner class hierarchy, we can move SVGStylable into SVGStyledElement. New interface for SVGElement: https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement

Attachments
First pass - still need to fix a couple build files. (51.34 KB, patch) 2013-01-14 23:54 PST, Philip Rogers	webkit-ews: commit-queue-	Details Formatted Diff Diff
Update all build systems (84.49 KB, patch) 2013-01-19 17:29 PST, Philip Rogers	webkit-ews: commit-queue-	Details Formatted Diff Diff
Add a ChangeLog entry somebody forgot (88.45 KB, patch) 2013-01-19 18:03 PST, Philip Rogers	webkit-ews: commit-queue-	Details Formatted Diff Diff
Update DerivedSources for QT EWS happiness. (89.64 KB, patch) 2013-01-19 18:22 PST, Philip Rogers	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Philip Rogers

Comment 1 2013-01-14 23:54:27 PST

Created attachment 182708 [details] First pass - still need to fix a couple build files.

Early Warning System Bot

Comment 2 2013-01-15 00:04:00 PST

Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15884484

Early Warning System Bot

Comment 3 2013-01-15 00:04:53 PST

Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15868807

EFL EWS Bot

Comment 4 2013-01-15 00:15:10 PST

Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15860847

Build Bot

Comment 5 2013-01-15 00:39:26 PST

Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15873784

Build Bot

Comment 6 2013-01-15 01:31:33 PST

Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15841865

Dirk Schulze

Comment 7 2013-01-15 08:47:11 PST

It builds on Chrome! 6 platforms to go! :)

Dirk Schulze

Comment 8 2013-01-15 08:50:59 PST

Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Should work better after modifying the ObjC bindings and the bindings for Qt and Gtk. But I would like to have a FIXME in SVGStyledElement.h that is should be combined with SVGElement after resolving cycle dependencies between SVGAnimationString and SVGElement (as specified in SVG2).

Philip Rogers

Comment 9 2013-01-19 17:29:20 PST

Created attachment 183646 [details] Update all build systems

Dirk Schulze

Comment 10 2013-01-19 17:33:29 PST

Comment on attachment 183646 [details] Update all build systems View in context: https://bugs.webkit.org/attachment.cgi?id=183646&action=review Patch looks great! Waiting for the bots before setting r+. > Source/WebCore/WebCore.exp.in:2634 > .objc_class_name_DOMSVGStyleElement Shouldn't you remove this one?

Philip Rogers

Comment 11 2013-01-19 17:35:18 PST

(In reply to comment #10) > (From update of attachment 183646 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183646&action=review > > Patch looks great! Waiting for the bots before setting r+. Yes, please do :) > > > Source/WebCore/WebCore.exp.in:2634 > > .objc_class_name_DOMSVGStyleElement > > Shouldn't you remove this one? No, that's for <style> which is still needed.

Early Warning System Bot

Comment 12 2013-01-19 17:37:26 PST

Comment on attachment 183646 [details] Update all build systems Attachment 183646 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15970388

Early Warning System Bot

Comment 13 2013-01-19 17:38:20 PST

Comment on attachment 183646 [details] Update all build systems Attachment 183646 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15974413

Dirk Schulze

Comment 14 2013-01-19 17:39:28 PST

(In reply to comment #11) > (In reply to comment #10) > > > Source/WebCore/WebCore.exp.in:2634 > > > .objc_class_name_DOMSVGStyleElement > > > > Shouldn't you remove this one? > > No, that's for <style> which is still needed. Ah right, mixed it up with Stylable.

Philip Rogers

Comment 15 2013-01-19 18:03:17 PST

Created attachment 183647 [details] Add a ChangeLog entry somebody forgot

Early Warning System Bot

Comment 16 2013-01-19 18:13:17 PST

Comment on attachment 183647 [details] Add a ChangeLog entry somebody forgot Attachment 183647 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15973431

Early Warning System Bot

Comment 17 2013-01-19 18:15:50 PST

Comment on attachment 183647 [details] Add a ChangeLog entry somebody forgot Attachment 183647 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15972395

Philip Rogers

Comment 18 2013-01-19 18:22:18 PST

Created attachment 183649 [details] Update DerivedSources for QT EWS happiness.

Philip Rogers

Comment 19 2013-01-19 19:03:29 PST

Comment on attachment 183649 [details] Update DerivedSources for QT EWS happiness. Bots seem happy! Marking for review

Dirk Schulze

Comment 20 2013-01-19 19:04:34 PST

Comment on attachment 183649 [details] Update DerivedSources for QT EWS happiness. r=me

WebKit Review Bot

Comment 21 2013-01-19 19:13:46 PST

Comment on attachment 183649 [details] Update DerivedSources for QT EWS happiness. Clearing flags on attachment: 183649 Committed r140265: <http://trac.webkit.org/changeset/140265>

WebKit Review Bot

Comment 22 2013-01-19 19:13:52 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.